Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Scroll To Text by default #19634

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Commits on Jan 16, 2020

  1. Enable Scroll To Text by default

    Enables scroll to text by default for M81. Note we plan to launch via
    Finch for M80.
    
    Intent to ship with LGTMs:
    https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ
    
    This patch also updates web platform test expectations:
    - scroll-to-text-fragment.html now passes; it just needed an extra rAF
      for the fallback to element anchor behavior.
    - scroll-to-text-fragment-security.html has two expected failures, as
      they need to be updated to test cross-origin navigations. I'll make
      this change in a follow-up patch to close bug 1042311.
    
    Bug: 919204
    Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838701
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Nick Burris <nburris@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#732592}
    Nick Burris authored and chromium-wpt-export-bot committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b774cc8 View commit details
    Browse the repository at this point in the history