[Import Maps] WPT: Check parsed import maps' scopes #19743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 16, 2019
Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706790}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1863854
branch
from
3d26be1
to
c178ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this CL, only
importsparts of import maps were tested.Chromium side:
rather than only the
importsvalue.the logic.
WPT side:
jest-test-helper.js.Remove fetch scheme restriction in scope keys WICG/import-maps#190 to
builtin-support.tentative/imported/resources/parsing-scope-keys.js.Test expectation changes:
parsing-scope-keys.tentative.htmlon Chromiumdue to the spec-inconformant behavior of Chromium's URL parser.
xto{imports: x, scopes: {}}.Bug: 990561, 927181
Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706790}