Remove fetch scheme restriction in scope keys #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Oct 16, 2019
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2019
Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 17, 2019
Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706790}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 17, 2019
Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706790}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 24, 2019
…aps' scopes, a=testonly Automatic update from web-platform-tests [Import Maps] WPT: Check parsed import maps' scopes Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706790} -- wpt-commits: dfaa0ba046478cb6db6284a4a036147b17d316d9 wpt-pr: 19743
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Oct 24, 2019
…aps' scopes, a=testonly Automatic update from web-platform-tests [Import Maps] WPT: Check parsed import maps' scopes Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706790} -- wpt-commits: dfaa0ba046478cb6db6284a4a036147b17d316d9 wpt-pr: 19743
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 27, 2019
…aps' scopes, a=testonly Automatic update from web-platform-tests [Import Maps] WPT: Check parsed import maps' scopes Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouheichromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Cr-Commit-Position: refs/heads/master{#706790} -- wpt-commits: dfaa0ba046478cb6db6284a4a036147b17d316d9 wpt-pr: 19743 UltraBlame original commit: 52907e7e763b51717f9c58d08c26aa5ae16454ce
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 27, 2019
…aps' scopes, a=testonly Automatic update from web-platform-tests [Import Maps] WPT: Check parsed import maps' scopes Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouheichromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Cr-Commit-Position: refs/heads/master{#706790} -- wpt-commits: dfaa0ba046478cb6db6284a4a036147b17d316d9 wpt-pr: 19743 UltraBlame original commit: 52907e7e763b51717f9c58d08c26aa5ae16454ce
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 27, 2019
…aps' scopes, a=testonly Automatic update from web-platform-tests [Import Maps] WPT: Check parsed import maps' scopes Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in WICG/import-maps#190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854 Reviewed-by: Kouhei Ueno <kouheichromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Cr-Commit-Position: refs/heads/master{#706790} -- wpt-commits: dfaa0ba046478cb6db6284a4a036147b17d316d9 wpt-pr: 19743 UltraBlame original commit: 52907e7e763b51717f9c58d08c26aa5ae16454ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188.
Preview | Diff