Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import Maps] WPT: Check parsed import maps' scopes #19743

Merged
merged 1 commit into from
Oct 17, 2019

Commits on Oct 17, 2019

  1. [Import Maps] WPT: Check parsed import maps' scopes

    Before this CL, only `imports` parts of import maps were tested.
    
    Chromium side:
    - This CL makes ImportMap::ToString() to output the whole import map,
      rather than only the `imports` value.
    - This CL removes white spaces for pretty printing, to simplify
      the logic.
    
    WPT side:
    - This CL checks the whole import maps in `jest-test-helper.js`.
    - Reflect the upstream changes in
      WICG/import-maps#190 to
      `builtin-support.tentative/imported/resources/parsing-scope-keys.js`.
    
    Test expectation changes:
    - This CL exposes new test failures in
      `parsing-scope-keys.tentative.html` on Chromium
      due to the spec-inconformant behavior of Chromium's URL parser.
    - Other test expectation changes are just converting
      `x` to `{imports: x, scopes: {}}`.
    
    Bug: 990561, 927181
    Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#706790}
    hiroshige-g authored and chromium-wpt-export-bot committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    c178ae3 View commit details
    Browse the repository at this point in the history