Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testharness.js] Preserve harness error message #20168

Merged
merged 1 commit into from
Nov 8, 2019
Merged

[testharness.js] Preserve harness error message #20168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions resources/testharness.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,8 +792,14 @@ policies and contribution forms [3].

function done() {
if (tests.tests.length === 0) {
tests.status.status = tests.status.ERROR;
tests.status.message = "done() was called without first defining any tests";
// `done` is invoked after handling uncaught exceptions, so if the
// harness status is already set, the corresponding message is more
// descriptive than the generic message defined here.
if (tests.status.status === null) {
tests.status.status = tests.status.ERROR;
tests.status.message = "done() was called without first defining any tests";
}

tests.complete();
return;
}
Expand Down