MediaRecorder: update mimeType on onstart. #20530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 29, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1893855
branch
7 times, most recently
from
ed079bb
to
625a159
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1893855
branch
from
625a159
to
87c3880
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1893855
branch
7 times, most recently
from
7ffa4c2
to
c45889a
Compare
This change brings the MediaRecorder onstart behavior to spec compliance, as per w3c/mediacapture-record#190. The change carries updates to web tests related to the following: - PeerConnection MediaRecorder tests have been added to cover the both spec wording related to avoiding transcoding and the normal transcoding use cases. - A test that shows that audio recording cannot happen without a sink tag has been added. - With this change, Chrome passes all the mime type tests. Bug: 1013590 Change-Id: I0001673fce20e995a3fe67336a7c9e87d70adc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893855 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#732487}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1893855
branch
from
c45889a
to
ced8703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the MediaRecorder onstart behavior to spec
compliance, as per w3c/mediacapture-record#190.
The change carries updates to web tests related to the following:
both spec wording related to avoiding transcoding and the normal
transcoding use cases.
tag has been added.
Bug: 1013590
Change-Id: I0001673fce20e995a3fe67336a7c9e87d70adc0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893855
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#732487}