Referrer Policy: inheritance with javascript: URLs and document.write() #21232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some existing tests and adds new tests with results I expect from reading the specification, but do not see confirmed in implementations.
This was referenced Jan 17, 2020
mikewest
approved these changes
Jan 19, 2020
| ].forEach(({ srcDocPolicy, expected }) => { | ||
| promise_test(t => { | ||
| return new Promise(resolve => { | ||
| window.addEventListener("message", t.step_func(msg => { |
There was a problem hiding this comment.
I don't think we need step_func in a promise_test, do we?
There was a problem hiding this comment.
This is what https://web-platform-tests.org/writing-tests/testharness-api.html#promise-tests suggests, but if I remove the wrappers I end up with a harness failure.
There was a problem hiding this comment.
That was a mistake in the documentation, #21269 fixed it.
|
Both Chrome and Firefox have (different) failures in iframe-inheritance-javascript.html and iframe-inheritance-javascript-child.html. Firefox also fails iframe-inheritance-document-write.html. The test is assuming that the policy of the document the URL executes in is the one supposed to be reused (i.e., the target not the source). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some existing tests and adds new tests with results I expect from reading the specification, but do not see confirmed in implementations.