COOP+COEP: javascript: URLs #21230
Merged
COOP+COEP: javascript: URLs #21230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
wpt-pr-bot
requested review from
arturjanc,
domenic,
foolip,
hemeryar,
jdm,
jgraham,
jugglinmike,
mikewest,
ParisMeuleman,
valenting,
zcorpan and
zqzhang
|
The idea is that a |
|
@ParisMeuleman @hemeryar ping. |
hemeryar
approved these changes
Feb 6, 2020
| t.add_cleanup(() => frame.remove()); | ||
| frame.src = "resources/coep-frame.html"; | ||
| frame.onload = t.step_func(() => { | ||
| frame.onload = null; |
There was a problem hiding this comment.
Just out of curiosity:
I have seen tests that assume this automatically for popups. Do we need it explicitely here because it is an iframe or because it is a javascript url?
There was a problem hiding this comment.
(Talking about frame.onload = null)
There was a problem hiding this comment.
Some browsers dispatch the load event for javascript URLs (as is required) and others did not. So if you do not do this, you end up with a loop, at least in some browsers.
annevk
force-pushed
the
annevk/coop-coep-javascript-urls
branch
from
6c19f0c
to
a54b263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.