Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some assert_throws('Something', stuff) calls with assert_throws_dom #21392

Merged
merged 1 commit into from Jan 23, 2020
Merged

Replace some assert_throws('Something', stuff) calls with assert_throws_dom #21392

merged 1 commit into from Jan 23, 2020

Conversation

stephenmcgruer
Copy link
Contributor

This a piece-by-piece landing of #21350 due to the size of the original PR. Please excuse the email spam when wpt-pr-bot cc's you to this PR.

@stephenmcgruer
Copy link
Contributor Author

@bzbarsky FYI

@bzbarsky
Copy link
Contributor

bzbarsky commented Jan 23, 2020 •
edited

Yep, gotcha.

How do I run those resources unit tests locally? They apparently don't get run in the Firefox CI.... :(

@stephenmcgruer
Copy link
Contributor Author

How do I run those tests locally?

Great question. I'm not sure offhand, I'll dig into it tomorrow and see. You can look at tools/ci/tc/tasks/test.yml to see what commands it runs for resources/ tests if you want to be eager ;)

@stephenmcgruer
Copy link
Contributor Author

As for this PR, stability check failures are the expected flakes, and the browser diffs look good (no change in any). Merging!

@stephenmcgruer stephenmcgruer merged commit d510304 into master Jan 23, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/bzbarsky_7 branch January 23, 2020 21:45
stephenmcgruer added a commit that referenced this pull request Jan 25, 2020
@stephenmcgruer
Fixup indentation from PR 21392
d238e98 
#21392 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.
stephenmcgruer added a commit that referenced this pull request Jan 27, 2020
@stephenmcgruer
Fixup indentation from PR 21392
63c2f71 
#21392 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.
@stephenmcgruer
Copy link
Contributor Author

@bzbarsky following up on resources/ tests, I believe running ./tools/ci/ci_resources_unittest.sh should work. It ultimately runs tox in the resources/test directory, so you could possibly just do that manually too (and thus filter to specific tests).

jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Feb 2, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1611618 [wpt PR 21422] - Fixup indentation from assert_throws ref…
53d4c22 
…actor, a=testonly

Automatic update from web-platform-tests
Fixup indentation from PR 21353

web-platform-tests/wpt#21353 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21354

web-platform-tests/wpt#21354 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21378

web-platform-tests/wpt#21378 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21379

web-platform-tests/wpt#21379 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21377

web-platform-tests/wpt#21377 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21390

web-platform-tests/wpt#21390 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21392

web-platform-tests/wpt#21392 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--

wpt-commits: e4499c8ff1ecf603ecbda020102ec9c956d594f6, 88ab2f0e4965b8e6ea61d3ff4f90ff5215de8a4e, 21578f29a8e82eff91c0fd43ad709fbf3fbe9e72, e836541f46abbd9272233578ad4e8ac0867bde15, f2961a22018844dae808cb12af6774ba8b435773, 597c0519c494486d18ab81a32a7206014ee23b5a, 63c2f7190b779112aa79d28a51cc29b98ca381dc
wpt-pr: 21422
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1611618 [wpt PR 21422] - Fixup indentation from assert_throws ref…
7cdccaa 
…actor, a=testonly

Automatic update from web-platform-tests
Fixup indentation from PR 21353

web-platform-tests/wpt#21353 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21354

web-platform-tests/wpt#21354 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21378

web-platform-tests/wpt#21378 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21379

web-platform-tests/wpt#21379 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21377

web-platform-tests/wpt#21377 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21390

web-platform-tests/wpt#21390 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21392

web-platform-tests/wpt#21392 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--

wpt-commits: e4499c8ff1ecf603ecbda020102ec9c956d594f6, 88ab2f0e4965b8e6ea61d3ff4f90ff5215de8a4e, 21578f29a8e82eff91c0fd43ad709fbf3fbe9e72, e836541f46abbd9272233578ad4e8ac0867bde15, f2961a22018844dae808cb12af6774ba8b435773, 597c0519c494486d18ab81a32a7206014ee23b5a, 63c2f7190b779112aa79d28a51cc29b98ca381dc
wpt-pr: 21422
@bzbarsky
Copy link
Contributor

bzbarsky commented Feb 5, 2020

@stephenmcgruer I tried running that and ran into the same problem I've run into every time I try to run these tests:

Exception: Could not start wptserve on http://web-platform.test:8000

@jgraham

@stephenmcgruer
Copy link
Contributor Author

Do you have a server already running on port 8000?

@bzbarsky
Copy link
Contributor

bzbarsky commented Feb 5, 2020

Nope.

@bzbarsky
Copy link
Contributor

bzbarsky commented Feb 5, 2020

Ah, if I manually run wpt serve I at least get an actionable error message:

CRITICAL:web-platform-tests:Failed probing domain www1.xn--n8j6ds53lwwkrqhv28a.web-platform.test. Please ensure all the necessary WPT subdomains are mapped to a loopback device in /etc/hosts. See https://github.com/web-platform-tests/wpt#running-the-tests for instructions.

Lemme see about that...

@bzbarsky
Copy link
Contributor

bzbarsky commented Feb 5, 2020

Yeah, there we go. Doing the hosts file thing gets me up and running.

@bzbarsky
Copy link
Contributor

bzbarsky commented Feb 5, 2020

I filed #21613 on improving the error reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic Awaiting requested review from domenic

@domfarolino domfarolino Awaiting requested review from domfarolino

@drott drott Awaiting requested review from drott

@ewilligers ewilligers Awaiting requested review from ewilligers

@fantasai fantasai Awaiting requested review from fantasai

@flackr flackr Awaiting requested review from flackr

@foolip foolip Awaiting requested review from foolip

@fserb fserb Awaiting requested review from fserb

@fsoder fsoder Awaiting requested review from fsoder

@graouts graouts Awaiting requested review from graouts

@guidou guidou Awaiting requested review from guidou

@hayatoito hayatoito Awaiting requested review from hayatoito

@henbos henbos Awaiting requested review from henbos

@hillbrad hillbrad Awaiting requested review from hillbrad

@Honry Honry Awaiting requested review from Honry

Assignees

@peterjoel peterjoel

Labels
2dcontext animation-worklet css-fonts cssom custom-elements dom domparsing eventsource feature-policy fetch geometry html IndexedDB infra loading media-source performance-timeline presentation-api service-workers shadow-dom svg testharness.js web-animations web-nfc webmessaging webrtc webrtc-quic websockets webvtt webxr wg-audiovideo_tt wg-css wg-html wg-immersive-web wg-secondscreen wg-svg wg-sw wg-webapps wg-webappsec wg-webperf wg-webplatform wg-webrtc workers xhr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephenmcgruer @bzbarsky @peterjoel @wpt-pr-bot