Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some "assert_throws(new FooError(), stuff)" calls with assert_throws_js #21354

Merged
merged 1 commit into from Jan 23, 2020
Merged

Replace some "assert_throws(new FooError(), stuff)" calls with assert_throws_js #21354

merged 1 commit into from Jan 23, 2020

Conversation

stephenmcgruer
Copy link
Contributor

This is an attempt to understand what part of #21350 is failing the CI; please excuse the email spam when wpt-pr-bot cc's you to this PR.

@bzbarsky
Copy link
Contributor

It's possible that these tests would work as expected if all of the changes in the original PR were applied together.

No, that shouldn't matter.

Looking at those tests,:

  1. css/css-properties-values-api/register-property-syntax-parsing.html -- this should have assert_throws_dom("SyntaxError", ...). It was using the wrong thing before, and since this test is generally failing in Firefox I didn't catch this part.
  2. css/css-properties-values-api/register-property.html -- same thing. I should probably have looked for new SyntaxError() explicitly and fixed those up separately....
  3. css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative.html -- same thing.
  4. css/css-typed-om/stylevalue-subclasses/numeric-objects/parse.tentative.html -- same thing.
  5. css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative.html -- same thing.
  6. css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative.html -- same thing.
  7. kv-storage/interface.https.html -- the "Same-realm brand checks" test should be using iframe.contentWindow.TypeError throughout.
  8. webrtc/RTCConfiguration-iceServers.html-- this is the SyntaxError thing.
  9. websockets/stream-tentative/constructor.any.js -- this is the SyntaxError thing.

Let's see how the rest of this stuff goes, and then I can do a separate PR to fix these tests properly. Thank you again for sorting through this!

@stephenmcgruer
Copy link
Contributor Author

Stability checks fail as expected, but results are good for all browsers (no diffs). Merging (this was reviewed in #21350)

@stephenmcgruer stephenmcgruer merged commit 2c5c3c4 into master Jan 23, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/bzbarsky_2 branch January 23, 2020 15:51
bzbarsky added a commit to bzbarsky/web-platform-tests that referenced this pull request Jan 23, 2020
@bzbarsky
Replace some more "assert_throws(new FooError(), stuff)" calls with a…
ccbef72 
…ssert_throws_js or assert_throws_dom.

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part of landing web-platform-tests#21354>.  The two manual fixups there address the issues that led to the revert.
bzbarsky added a commit to bzbarsky/web-platform-tests that referenced this pull request Jan 23, 2020
@bzbarsky
Replace some more "assert_throws(new FooError(), stuff)" calls with a…
759b407 
…ssert_throws_js or assert_throws_dom.

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part
of landing <web-platform-tests#21354>.
The two manual fixups there address the issues that led to the revert.
@bzbarsky bzbarsky mentioned this pull request Jan 23, 2020
Merged
@bzbarsky
Copy link
Contributor

and then I can do a separate PR to fix these tests properly

#21380

@stephenmcgruer stephenmcgruer mentioned this pull request Jan 23, 2020
Merged
bzbarsky added a commit to bzbarsky/web-platform-tests that referenced this pull request Jan 23, 2020
@bzbarsky
Replace some more "assert_throws(new FooError(), stuff)" calls with a…
b933432 
…ssert_throws_js or assert_throws_dom.

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part
of landing <web-platform-tests#21354>.
The two manual fixups there address the issues that led to the revert.
stephenmcgruer pushed a commit that referenced this pull request Jan 23, 2020
@bzbarsky @stephenmcgruer
Replace some more "assert_throws(new FooError(), stuff)" calls with a…
9940584 
…ssert_throws_js or assert_throws_dom. (#21380)

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part
of landing <#21354>.
The two manual fixups there address the issues that led to the revert.
stephenmcgruer added a commit that referenced this pull request Jan 25, 2020
@stephenmcgruer
Fixup indentation from PR 21354
d878e4e 
#21354 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.
stephenmcgruer added a commit that referenced this pull request Jan 27, 2020
@stephenmcgruer
Fixup indentation from PR 21354
88ab2f0 
#21354 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jan 27, 2020
@bzbarsky @moz-wptsync-bot
Bug 1611189 [wpt PR 21380] - Replace some more "assert_throws(new Foo…
8c7b121 
…Error(), stuff)" calls with a…, a=testonly

Automatic update from web-platform-tests
Replace some more "assert_throws(new FooError(), stuff)" calls with assert_throws_js or assert_throws_dom. (#21380)

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part
of landing <web-platform-tests/wpt#21354>.
The two manual fixups there address the issues that led to the revert.
--

wpt-commits: 9940584f86638e9e558928d0a5fc7266f1848cec
wpt-pr: 21380
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 28, 2020
@bzbarsky @moz-wptsync-bot
Bug 1611189 [wpt PR 21380] - Replace some more "assert_throws(new Foo…
c764d18 
…Error(), stuff)" calls with a…, a=testonly

Automatic update from web-platform-tests
Replace some more "assert_throws(new FooError(), stuff)" calls with assert_throws_js or assert_throws_dom. (#21380)

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part
of landing <web-platform-tests/wpt#21354>.
The two manual fixups there address the issues that led to the revert.
--

wpt-commits: 9940584f86638e9e558928d0a5fc7266f1848cec
wpt-pr: 21380
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jan 28, 2020
@marco-c
Bug 1611189 [wpt PR 21380] - Replace some more "assert_throws(new Foo…
dd2e0a2 
…Error(), stuff)" calls with a…, a=testonly

Automatic update from web-platform-tests
Replace some more "assert_throws(new FooError(), stuff)" calls with assert_throws_js or assert_throws_dom. (#21380)

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part
of landing <web-platform-tests/wpt#21354>.
The two manual fixups there address the issues that led to the revert.
--

wpt-commits: 9940584f86638e9e558928d0a5fc7266f1848cec
wpt-pr: 21380

UltraBlame original commit: 9ea48d16df286ee13c9d96a6421a25a2d8b72118
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jan 28, 2020
@marco-c
Bug 1611189 [wpt PR 21380] - Replace some more "assert_throws(new Foo…
425960e 
…Error(), stuff)" calls with a…, a=testonly

Automatic update from web-platform-tests
Replace some more "assert_throws(new FooError(), stuff)" calls with assert_throws_js or assert_throws_dom. (#21380)

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

on the relevant files and then:

1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).

2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.

Note: these are the files which had changes to them reverted as part
of landing <web-platform-tests/wpt#21354>.
The two manual fixups there address the issues that led to the revert.
--

wpt-commits: 9940584f86638e9e558928d0a5fc7266f1848cec
wpt-pr: 21380

UltraBlame original commit: 9ea48d16df286ee13c9d96a6421a25a2d8b72118
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Feb 2, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1611618 [wpt PR 21422] - Fixup indentation from assert_throws ref…
53d4c22 
…actor, a=testonly

Automatic update from web-platform-tests
Fixup indentation from PR 21353

web-platform-tests/wpt#21353 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21354

web-platform-tests/wpt#21354 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21378

web-platform-tests/wpt#21378 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21379

web-platform-tests/wpt#21379 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21377

web-platform-tests/wpt#21377 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21390

web-platform-tests/wpt#21390 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21392

web-platform-tests/wpt#21392 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--

wpt-commits: e4499c8ff1ecf603ecbda020102ec9c956d594f6, 88ab2f0e4965b8e6ea61d3ff4f90ff5215de8a4e, 21578f29a8e82eff91c0fd43ad709fbf3fbe9e72, e836541f46abbd9272233578ad4e8ac0867bde15, f2961a22018844dae808cb12af6774ba8b435773, 597c0519c494486d18ab81a32a7206014ee23b5a, 63c2f7190b779112aa79d28a51cc29b98ca381dc
wpt-pr: 21422
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1611618 [wpt PR 21422] - Fixup indentation from assert_throws ref…
7cdccaa 
…actor, a=testonly

Automatic update from web-platform-tests
Fixup indentation from PR 21353

web-platform-tests/wpt#21353 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21354

web-platform-tests/wpt#21354 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21378

web-platform-tests/wpt#21378 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21379

web-platform-tests/wpt#21379 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21377

web-platform-tests/wpt#21377 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21390

web-platform-tests/wpt#21390 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--
Fixup indentation from PR 21392

web-platform-tests/wpt#21392 used an approach
which was known to cause indentation problems in some cases. This commit
is an attempt to fixup any indentation issues, by running a (hacky)
script to parse the diff and locate places where indentation was broken.

--

wpt-commits: e4499c8ff1ecf603ecbda020102ec9c956d594f6, 88ab2f0e4965b8e6ea61d3ff4f90ff5215de8a4e, 21578f29a8e82eff91c0fd43ad709fbf3fbe9e72, e836541f46abbd9272233578ad4e8ac0867bde15, f2961a22018844dae808cb12af6774ba8b435773, 597c0519c494486d18ab81a32a7206014ee23b5a, 63c2f7190b779112aa79d28a51cc29b98ca381dc
wpt-pr: 21422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky bzbarsky bzbarsky left review comments

@garykac garykac Awaiting requested review from garykac

@GPHemsley GPHemsley Awaiting requested review from GPHemsley

@graouts graouts Awaiting requested review from graouts

@grorg grorg Awaiting requested review from grorg

@gsnedders gsnedders Awaiting requested review from gsnedders

@guidou guidou Awaiting requested review from guidou

@hayatoito hayatoito Awaiting requested review from hayatoito

@henbos henbos Awaiting requested review from henbos

@hillbrad hillbrad Awaiting requested review from hillbrad

@Honry Honry Awaiting requested review from Honry

@igrigorik igrigorik Awaiting requested review from igrigorik

@inexorabletash inexorabletash Awaiting requested review from inexorabletash

@jan-ivar jan-ivar Awaiting requested review from jan-ivar

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

Assignees

@wisniewskit wisniewskit

Labels
2dcontext assets beacon bluetooth clipboard-apis compression content-security-policy css-animations css-conditional css-properties-values-api css-transitions css-typed-om cssom cssom-view custom-elements dom domparsing domxpath encoding fetch FileAPI filter-effects fullscreen generic-sensor geolocation-API geometry html IndexedDB infra js kv-storage media-source mediacapture-image mediacapture-streams mediasession mimesniff notifications offscreen-canvas payment-method-id payment-request performance-timeline presentation-api priority-hints scroll-animations selection service-workers speech-api std-toast streams svg testharness.js touch-events trusted-types uievents url user-timing vibration wasm web-share webaudio webgl webidl webmessaging webrtc webrtc-extensions websockets webstorage webxr wg-audio wg-css wg-das wg-dom wg-geolocation wg-html wg-immersive-web wg-media wg-payments wg-secondscreen wg-svg wg-sw wg-webapps wg-webevents wg-webperf wg-webplatform wg-webrtc workers xhr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephenmcgruer @bzbarsky @wisniewskit @wpt-pr-bot