Set up py3-only tools/quic and its venv #23075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgraham you probably want to skip the two commits generated by |
Hexcles
commented
Apr 17, 2020
jgraham
requested changes
Apr 20, 2020
|
@jgraham I've addressed your comments; PTAL again, thanks! |
jgraham
approved these changes
Apr 21, 2020
This does not include the actual server, but only sets up the skeleton: * Introduce a "py3only" to commands.json * Create the skeleton of tools/quic and set up its venv The plan is to have `wpt serve` call `wpt servequic` (behind a flag). For more details, see https://github.com/web-platform-tests/rfcs/blob/master/rfcs/quic.md
git-subtree-dir: tools/third_party/aioquic git-subtree-split: 88f258ae47b7ec85de5ecf4104665054b969a9bb
…rd_party/aioquic'
Hexcles
added a commit
that referenced
this pull request
May 27, 2020
I accientally squash-merged #23075 and screwed up the subtree setup, so I'm deleting the whole directory and re-introduce the subtree in the next commit.
Hexcles
added a commit
that referenced
this pull request
May 27, 2020
I accidentally squash-merged #23075 and screwed up the subtree setup, so I'm deleting the whole directory and re-introduce the subtree in the next commit.
Hexcles
added a commit
that referenced
this pull request
May 28, 2020
I accidentally squash-merged #23075 and screwed up the subtree setup, so I'm deleting the whole directory and re-introduce the subtree in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not include the actual server, but only sets up the skeleton:
git subtree add --prefix tools/third_party/aioquic https://github.com/aiortc/aioquic.git 0.8.7 --squash(note that this is checked in but not used at the moment)The plan is to have
wpt servecallwpt servequic(behind a flag).For more details, see
https://github.com/web-platform-tests/rfcs/blob/master/rfcs/quic.md
Tracking issue: #19114