Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak lints and checks for tools/quic #23078

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Tweak lints and checks for tools/quic #23078

merged 2 commits into from
Apr 21, 2020

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Apr 17, 2020

in preparation for #22844

Tracking issue: #19114

@Hexcles Hexcles assigned jgraham and unassigned KyleJu Apr 17, 2020
@Hexcles Hexcles requested a review from jgraham April 17, 2020 21:15
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-23078 April 17, 2020 21:17 Inactive
@Hexcles
Copy link
Member Author

Hexcles commented Apr 17, 2020

I promise I'll add proper support to manifest later, as per the RFC.

Also we should probably run mypy in Python 3 mode against tools/quic, but that's also for a later day.

tools/lint/lint.py Outdated Show resolved Hide resolved
tools/lint/lint.py Outdated Show resolved Hide resolved
* handlers: .quic.py files are Python 3-only so don't try to parse them.
* tests: add "quic" as a valid kind of metadata (note that manifest
  support hasn't been implemented yet).
It contains code invalid in Python 2.

Drive-by: rename py36-flake8.ini to py3-flake8.ini as it's used by
multiple Python 3 versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants