New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data URL dedicated workers and agent clusters #23137
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, so browsers don't even do this for iframes...
|
||
[ | ||
new SharedArrayBuffer(), | ||
new WebAssembly.Module(new WasmModuleBuilder().toBuffer()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test WebAssembly.Memory too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That follows the underlying object (a literal AB or SAB) so I don't think it's needed, but we could. If you also wanted to test it backed by AB though we'd have to invert all the pass conditions for that variant.
...cture/safe-passing-of-structured-data/shared-array-buffers/data-url-agent-cluster.https.html
Show resolved
Hide resolved
...cture/safe-passing-of-structured-data/shared-array-buffers/data-url-agent-cluster.https.html
Show resolved
Hide resolved
t.add_cleanup(() => frame.remove()); | ||
frame.onload = t.step_func(() => { | ||
self.addEventListener("message", t.step_func(({ data }) => { | ||
assert_equals(data, "PASS"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can never happen since both message and messageerror will cause a "FAIL" to be posted? More reason to change the messages posted in the way I describe above.
FYI this appears to be "working as intended" at Firefox 77. |
Thanks @domenic, hopefully this is a bit better. |
One item this test reveals is that |
@guest271314 that sounds like a bug. Can you create a separate test for that? I'll add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Glad to see that frames are in a separate agent cluster after all.
Not sure if that is currently testable and verifiable at WPT, see #20284 (comment). Opened
Should a Firefox bug be filed? |
@guest271314 I'd make a test for module workers to ensure it's enforced there. Perhaps also with a blob URL and such. If user agents eventually also enforce things for classic workers we could extend those tests. |
For whatwg/html#5476.