Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QuicTransport] Address comments in pull/22844 #23705

Merged
merged 2 commits into from
May 20, 2020
Merged

[QuicTransport] Address comments in pull/22844 #23705

merged 2 commits into from
May 20, 2020

Conversation

yutakahirano
Copy link
Contributor

Address comments provided in
#22844.

@yutakahirano
Copy link
Contributor Author

@vasilvv @ricea can you take a look?

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-23705 May 20, 2020 07:15 Inactive
@yutakahirano yutakahirano mentioned this pull request May 20, 2020
Merged
ricea
ricea approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tools/quic/quic_transport_server.py Outdated Show resolved Hide resolved
vasilvv
vasilvv approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@vasilvv vasilvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yutakahirano
Copy link
Contributor Author

Thanks!

@yutakahirano yutakahirano merged commit 6e5e590 into master May 20, 2020
@yutakahirano yutakahirano deleted the yhirano/quic-transport-followup branch May 20, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasilvv vasilvv vasilvv approved these changes

@ricea ricea ricea approved these changes

@Hexcles Hexcles Awaiting requested review from Hexcles

@jgraham jgraham Awaiting requested review from jgraham

@LukeZielinski LukeZielinski Awaiting requested review from LukeZielinski

@stephenmcgruer stephenmcgruer Awaiting requested review from stephenmcgruer

Assignees

@jgraham jgraham

Labels
infra quic webtransport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yutakahirano @vasilvv @ricea @jgraham @wpt-pr-bot