-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update python version in build for html/canvas #24685
Conversation
The concern is initially raised here: |
Taking notes for my own understanding:
What I'm a little confused by is the conversation in 6a53164 - it seems to imply that one set of people had problems running this in Python 2 (mysteryDate mentioned this) whilst another set had problems running this in Python 3 (yiyix said this). The goal of this change seems to be to let it use whatever the system Python is, but it seems like we aren't sure that will always work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgraham Do you object to this, you thought the CI bots were mad when we made it version agnostic? |
FWIW, I don't object to this if it works in both 2 and 3, but I remember this was pinned to Python 2 specifically because of some issues on (Gecko?) CI. |
In my local set up, it works for both python 2 and 3. My teammate @mysteryDate did some refactor here and he is able to re-generate all script tests with both python2 and python3. |
It could be because Mozilla use an older Python 3 internally (I believe they were still targeting Python 3.5 last time I checked). Let me ping @jgraham again and see if they know - sorry @yiyix to drag this on further :( That said, I did try locally with 3.5.6 and the build.sh script worked fine for me in that environment. |
I don't have any specific concerns about Gecko CI here; I don't think we run this. I'm somewhat wary of getting different results from Python 2 vs 3 in the canvas stuff, but I suppose I'm also pretty wary of getting different results based on a number of other factors there and it seems to work out. |
It's currently building with virtualenv -p python2 .virtualenv, which requires python2 specifically. Updated to use python, so it's compatible with both python2 and python3.