Fix defaultValue-clobbering.html #25442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally wrote this test in chromium using chromium's separate wpt test runner, but it turns out that the test was timing out on wpt's actual test runner, likely due to using a reftest and testdriver at the same time. This patch tests the same behavior in a different way and doesn't use reftesting so the test doesn't time out anymore.
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
tkent-google,
zcorpan and
zqzhang
tkent-google
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally wrote this test in chromium using chromium's separate wpt
test runner, but it turns out that the test was timing out on wpt's
actual test runner, likely due to using a reftest and testdriver at the
same time.
This patch tests the same behavior in a different way and doesn't use
reftesting so the test doesn't time out anymore.