Increase maximum open files for each server process on Darwin (WebKit export) #25773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugs.webkit.org/show_bug.cgi?id=215829 Patch by Sam Sneddon <gsnedders@apple.com> on 2020-09-21 Reviewed by Youenn Fablet. macOS has a much lower limits than other OSes by default, and the iOS bots often run into it with their level of parallel test execution. This bumps the limit for each wptserve process up to 2048, which is double the limit on Debian, and should probably be safe. * web-platform-tests/tools/serve/serve.py: (ServerProc.create_daemon): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267354 268f45c-cd09-0410-ab3c-d52691b4dbfc
…gs.webkit.org/show_bug.cgi?id=216823 Patch by Sam Sneddon <gsnedders@apple.com> on 2020-09-22 Reviewed by Darin Adler. * web-platform-tests/tools/serve/serve.py: Move the resource import to the local point behind the Darwin platform test. This code is only run once per process initiation, hence it makes no difference to have the import locally. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267417 268f45c-cd09-0410-ab3c-d52691b4dbfc
wpt-pr-bot
requested review from
Hexcles,
jgraham,
LukeZielinski and
stephenmcgruer
Hexcles
reviewed
Sep 24, 2020
|
Note that this might have been answered in the WebKit issue which timed out loading for me... |
|
@Hexcles remember that sockets are also FDs; it's quite possibly #8369 showing its face again (where the majority of FDs are TCP sockets in the TIME_WAIT state) combined with Darwin having a much lower default RLIMIT_NOFILE (256, versus 1024 on most of the Linux systems I've looked on) and the iOS bots running with multiple bots hitting a single server. |
Hexcles
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export of https://bugs.webkit.org/show_bug.cgi?id=215829 & its regression fix https://bugs.webkit.org/show_bug.cgi?id=216823.
Delayed export to verify that this stopped the failures from happening, and we've not seen any over the past three days so I'm assume this fixed it.