Add a test for backdrop filter underlapping a border #27160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 13, 2021
A recent bug [1] showed that in SkiaRenderer, it was possible for a backdrop-filter element to blend pixels from a neighboring (but not underlapping) render pass, due to some clipping issues. This test checks for this situation. The original bug was fixed in [2], but I verified that this test breaks pre-[2] (see patchset 1 of this CL). [1] https://crbug.com/1162743 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2611452 Bug: 1162743 Change-Id: I86d00d9831057ace40476d29848c11ba1b671a82 Fixed: 1165868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625156 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843000}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2625156
branch
from
d3e5182
to
a4aba22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent bug [1] showed that in SkiaRenderer, it was possible for a
backdrop-filter element to blend pixels from a neighboring (but not
underlapping) render pass, due to some clipping issues. This test
checks for this situation.
The original bug was fixed in [2], but I verified that this test
breaks pre-[2] (see patchset 1 of this CL).
[1] https://crbug.com/1162743
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2611452
Bug: 1162743
Change-Id: I86d00d9831057ace40476d29848c11ba1b671a82
Fixed: 1165868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625156
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843000}