Add a test for backdrop filter underlapping a border #27160
Merged
+77
−0
Conversation
|
The review process for this patch is being conducted in the Chromium project. |
A recent bug [1] showed that in SkiaRenderer, it was possible for a backdrop-filter element to blend pixels from a neighboring (but not underlapping) render pass, due to some clipping issues. This test checks for this situation. The original bug was fixed in [2], but I verified that this test breaks pre-[2] (see patchset 1 of this CL). [1] https://crbug.com/1162743 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2611452 Bug: 1162743 Change-Id: I86d00d9831057ace40476d29848c11ba1b671a82 Fixed: 1165868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625156 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843000}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2625156
branch
from
d3e5182
to
a4aba22
chromium-wpt-export-bot
merged commit e9e281d
into
master
23 checks passed
23 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A recent bug [1] showed that in SkiaRenderer, it was possible for a
backdrop-filter element to blend pixels from a neighboring (but not
underlapping) render pass, due to some clipping issues. This test
checks for this situation.
The original bug was fixed in [2], but I verified that this test
breaks pre-[2] (see patchset 1 of this CL).
[1] https://crbug.com/1162743
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2611452
Bug: 1162743
Change-Id: I86d00d9831057ace40476d29848c11ba1b671a82
Fixed: 1165868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625156
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843000}