Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-contain] rename files in vendor-imports that also exist in the main suite #27487

Merged
merged 1 commit into from Feb 5, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 4, 2021

A number of filenames are used in both css/css-contain/ and
css/vendor-imports/mozilla/mozilla-central-reftests/contain/ but aren't
the same tests, having different authors and structure.

In order to make a merge of the directories easier, first rename as few
files as possible in vendor-imports to avoid all name clashes.

Part of #8615.

…ain suite

A number of filenames are used in both css/css-contain/ and
css/vendor-imports/mozilla/mozilla-central-reftests/contain/ but aren't
the same tests, having different authors and structure.

In order to make a merge of the directories easier, first rename as few
files as possible in vendor-imports to avoid all name clashes.

Part of #8615.
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun.

@Ms2ger Ms2ger merged commit b6d3b75 into master Feb 5, 2021
@Ms2ger Ms2ger deleted the foolip/css-contain-collisions branch February 5, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants