[Gecko Bug 1700640] Map width and height to aspect-ratio in <canvas>, <input type=image>, and <video>. #28229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and <video>. As per https://html.spec.whatwg.org/#attributes-for-embedded-content-and-images: > The width and height attributes map to the aspect-ratio property on > img, canvas, and video elements, and input elements with a type > attribute in the Image Button state. See whatwg/html#6527 for the parsing issue with canvas and zero. For now allow both behaviors in the tests. We also remove the width-and-height-map-to-aspect-ratio pref, as it is true everywhere and has been for a while. Differential Revision: https://phabricator.services.mozilla.com/D109618 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1700640 gecko-commit: 985b66b916980b78328063dfdccdc5e5b71318e5 gecko-reviewers: boris
wpt-pr-bot
approved these changes
Mar 24, 2021
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 25, 2021
Also map <canvas width height> to aspect-ratio consistently with how the attributes are parsed. Tests: web-platform-tests/wpt#28229. Follow-up: #6528. Closes #4961 and closes #6527.
3 tasks
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 12, 2021
Also map <canvas width height> to aspect-ratio consistently with how the attributes are parsed and clean up some wording. Tests: web-platform-tests/wpt#28229 & web-platform-tests/wpt#28932. Follow-up: #6528. Closes #4961 and closes #6527.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://html.spec.whatwg.org/#attributes-for-embedded-content-and-images:
See whatwg/html#6527 for the parsing issue
with canvas and zero. For now allow both behaviors in the tests.
We also remove the width-and-height-map-to-aspect-ratio pref, as it is
true everywhere and has been for a while.
Differential Revision: https://phabricator.services.mozilla.com/D109618
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1700640
gecko-commit: 985b66b916980b78328063dfdccdc5e5b71318e5
gecko-reviewers: boris