Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: update aspect-ratio rendering tests #28932

Merged
merged 1 commit into from May 12, 2021
Merged

HTML: update aspect-ratio rendering tests #28932

merged 1 commit into from May 12, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented May 10, 2021

@annevk annevk requested review from emilio and cbiesinger May 10, 2021 11:50
@annevk annevk mentioned this pull request May 10, 2021
Merged
3 tasks
emilio
emilio approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@annevk annevk merged commit 8d656c5 into master May 12, 2021
@annevk annevk deleted the annevk/aspect-ratio-tests branch May 12, 2021 10:59
annevk added a commit to whatwg/html that referenced this pull request May 12, 2021
@annevk
Support zero dimension values for aspect-ratio
e2f08b4 
Also map <canvas width height> to aspect-ratio consistently with how the attributes are parsed and clean up some wording.

Tests: web-platform-tests/wpt#28229 & web-platform-tests/wpt#28932.

Follow-up: #6528.

Closes #4961 and closes #6527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

@cbiesinger cbiesinger Awaiting requested review from cbiesinger

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@domenic domenic

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@annevk @emilio @domenic @wpt-pr-bot