Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependencies of idlharness.js tests #28544

Merged
merged 1 commit into from Apr 16, 2021
Merged

Add missing dependencies of idlharness.js tests #28544

merged 1 commit into from Apr 16, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 16, 2021

These tests are all slightly broken due to these missing dependencies.

@foolip
Add missing dependencies of idlharness.js tests
bc6e856 
These tests are all slightly broken due to these missing dependencies.
@foolip
Copy link
Member Author

foolip commented Apr 16, 2021

Looks at the diffs on wpt.fyi I think I got this right:
https://wpt.fyi/results/?diff&filter=ADC&q=is%3Adifferent&run_id=5687769110151168&run_id=5720067264217088
https://wpt.fyi/results/?diff&filter=ADC&run_id=5420440010883072&run_id=5640206038335488
https://wpt.fyi/results/?diff&filter=ADC&run_id=5678746256277504&run_id=6326030845345792

@foolip foolip requested a review from Ms2ger April 16, 2021 13:24
@Ms2ger Ms2ger merged commit a353845 into master Apr 16, 2021
@Ms2ger Ms2ger deleted the foolip/idl-deps branch April 16, 2021 13:37
foolip added a commit that referenced this pull request Apr 16, 2021
@foolip
Fix test_tests_affected_idlharness
458e11c 
Broken by #28544, where
this test didn't run. It's the addition of webrtc as a dependency there
that is the broken, as commit 47cea8c
updates webrtc.idl.

This test is indeed funny, depending both on an old commit and on the
current state of the tree...
@foolip foolip mentioned this pull request Apr 16, 2021
Merged
@foolip
Copy link
Member Author

foolip commented Apr 16, 2021

Ooops, this broke tests: #28545

foolip added a commit that referenced this pull request Apr 16, 2021
@foolip
Fix test_tests_affected_idlharness (#28545)
8e27403 
Broken by #28544, where
this test didn't run. It's the addition of webrtc as a dependency there
that is the broken, as commit 47cea8c
updates webrtc.idl.

This test is indeed funny, depending both on an old commit and on the
current state of the tree...
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 24, 2021
@foolip @moz-wptsync-bot
Bug 1705738 [wpt PR 28545] - Fix test_tests_affected_idlharness, a=te…
43ee1fa 
…stonly

Automatic update from web-platform-tests
Fix test_tests_affected_idlharness (#28545)

Broken by web-platform-tests/wpt#28544, where
this test didn't run. It's the addition of webrtc as a dependency there
that is the broken, as commit 47cea8c38b88c0ddd3854e4edec0c5b6f2697e62
updates webrtc.idl.

This test is indeed funny, depending both on an old commit and on the
current state of the tree...
--

wpt-commits: 8e27403264a86945d72eced0e86ad26833466bf2
wpt-pr: 28545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@alvestrand alvestrand Awaiting requested review from alvestrand

@jdm jdm Awaiting requested review from jdm

@NavidZ NavidZ Awaiting requested review from NavidZ

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@zqzhang zqzhang

Labels
mst-content-hint uievents webrtc-encoded-transform wg-s_webrtc wg-webapps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@foolip @Ms2ger @zqzhang @wpt-pr-bot @moz-wptsync-bot