Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAVE test runner #30357

Merged

Conversation

FritzHeiden
Copy link
Contributor

@FritzHeiden FritzHeiden commented Sep 6, 2021

This PR brings the latest changes to the WAVE test runner, including support for Python 3, bug fixes and other minor improvements.

@jgraham
Copy link
Contributor

jgraham commented Sep 13, 2021

@sunettt you might be interested in following this update.

@FritzHeiden FritzHeiden changed the title [WIP] Update WAVE test runner Update WAVE test runner Oct 13, 2021
- Updated reference browser result links
- Fixed configuration page to properly display reference results
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually reviewed the changes in detail since they all seem to be in tools/wave. So this is an approval from the point of view of "this is an acceptable change to land in the context of wpt as a whole", not "this specific set of modifications are the right thing from the point of view of the wave runner".

@JohnRiv
Copy link

JohnRiv commented Nov 10, 2021

Thanks for the review!

As the chair of the HATF group in WAVE responsible for this, I approve from the perspective of "this specific set of modifications are the right thing from the point of view of the wave runner" ✅

If you need anything else from us to merge this in, please let @FritzHeiden and I know. Thank you.

@jgraham jgraham merged commit e5c7faa into web-platform-tests:master Nov 16, 2021
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants