Add test for event propagation on disabled form controls #32381

jgraham · 2022-01-14T11:37:20Z

No description provided.

jgraham · 2022-01-14T14:22:16Z

https://wpt.fyi/results/html/semantics/forms/event-propagate-disabled.html?label=pr_head&max-count=1&pr=32381

Currently this semi-matches Safari. Chrome seems to not be generating click events at all in this case, but does generate and bubble mousedown and mouseup, and Firefox isn't bubbling any events.

foolip · 2022-03-29T16:12:20Z

All of the tests fail in all browsers, is that expected? Isn't the behavior of some browser sensible enough to align on?

jgraham · 2022-03-29T18:16:50Z

@saschanaz might be better to answer that question

jgraham · 2022-03-29T18:41:02Z

But Chrome seems to special case disabled form controls to not get a click event, whereas per the test results, Firefox and Safari don't give any mouse events on those controls. I think there are some further differences between Firefox and Safari, but I've forgotten exactly what they are.

(I'm going to close and reopen to update the results in case browsers changed since the test was written).

foolip · 2022-03-30T07:49:08Z

https://wpt.fyi/results/html/semantics/forms/event-propagate-disabled.html?label=pr_head&max-count=1&pr=32381 is now CRASH in Safari, but still all failing in Chrome and Firefox, so probably the same situation still.

saschanaz · 2022-03-30T07:58:05Z

Chrome seems to not be generating click events at all in this case,

Chrome does bubble clicks, please check whether you enabled Experimental Web Platform features flag as the flag blocks bubbling. Demo:

data:text/html;charset=utf-8,<body onclick="console.log('click')" onmousedown="console.log('mousedown')"><input type="text" disabled>

(See also whatwg/html#2368 (comment))

jgraham · 2022-03-30T08:27:45Z

Yeah, we're running this in Chrome dev with the flag set; it sounds like Chrome release might pass the tests as written? Do you happen to know why the experimental flag is blocking (just) click events in this case?

saschanaz · 2022-03-30T08:36:03Z

I have no idea, they once wanted to align with Firefox perhaps?

html/semantics/forms/event-propagate-disabled.html

foolip · 2022-03-30T14:48:40Z

That "SendMouseEventsDisabledFormControls" feature was added in https://source.chromium.org/chromium/chromium/src/+/af6f27363128a72a89cb581f3073c0e068854308 but was never moved out of experimental.

I've run the test locally with ./wpt run --channel stable chrome html/semantics/forms/event-propagate-disabled.html and all the same tests fail, but instead of getting 2 events (3 expected) there are 0 events fired.

Per https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#enabling-and-disabling-form-controls:-the-disabled-attribute only the "click" event should be dropped, so maybe the per-spec behavior is what Chrome does with "SendMouseEventsDisabledFormControls" enabled is correct, and the test should match that?

jgraham · 2022-03-31T16:33:08Z

Well I've updated it a bit, but I'm still not sure what behaviour we actually want to align on. In particular Chrome is still failing the tests for select elements.

html/semantics/forms/event-propagate-disabled.html

josepharhar · 2022-04-07T20:11:33Z

Thanks for making this test! It looks quite comprehensive with bubbling and child elements. Do you think it would be possible to also test mousemove, pointerdown, pointerup, and pointermove?

josepharhar · 2022-06-28T17:31:54Z

Would it also be possible to look at event.composedPath() in this test? It is likely another compat issue we will need to address

…abled

saschanaz · 2022-06-28T23:10:11Z

Added it. For now it just includes all nodes as Blink/WebKit do, only to not complicate things before we know what should be done there. I'll adjust it based on the consensus from the next triage meeting.

saschanaz · 2022-07-05T14:15:45Z

I added some more tests for internal request.

Short report:

Both Firefox and Chrome blocks mousedown/up when disabled during immediate propagation, but does not block click
Both Firefox and Chrome changes focuses to the form elements and but Chrome then removes the focus when it's disabled by event listener.

Haven't tested on Safari yet.

jgraham · 2022-07-06T16:12:42Z

Note that https://wpt.fyi/results/html/semantics/forms?label=pr_head&max-count=1&pr=32381 has the latest results for the PR, including in Safari.

saschanaz · 2022-07-06T16:16:42Z

(The current assertions, especially in the new tests (-immediate and -by-parent) are not exactly the requirements. I'll adjust them as we better understand what should be done, hopefully after the triage. For now they are to show the differences.)

saschanaz · 2022-07-06T17:08:59Z

(I wanted to cover over/out events and then found a separate Gecko bug. I think the behavior is same there anyway, so let's just not complicate this further until it's fixed.)

Filed w3c/pointerevents#454.

…abled

Corresponds to the latest consensus and also matches what Chrome shipped behind `--enable-blink-features=SendMouseEventsDisabledFormControls`. Imported the portion of tests that is directly impacted here from #32381. Others are not directly impacted and thus I'd like to land them separately since there are still some mismatching behavior around `button` element. Differential Revision: https://phabricator.services.mozilla.com/D161537 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1799565 gecko-commit: dc3970db7ae2ad12db0cfb4ff794fa1f974a74e3 gecko-reviewers: smaug

…ly r=smaug Corresponds to the latest consensus and also matches what Chrome shipped behind `--enable-blink-features=SendMouseEventsDisabledFormControls`. Imported the portion of tests that is directly impacted here from web-platform-tests/wpt#32381. Others are not directly impacted and thus I'd like to land them separately since there are still some mismatching behavior around `button` element. Differential Revision: https://phabricator.services.mozilla.com/D161537

Corresponds to the latest consensus and also matches what Chrome shipped behind `--enable-blink-features=SendMouseEventsDisabledFormControls`. Imported the portion of tests that is directly impacted here from #32381. Others are not directly impacted and thus I'd like to land them separately since there are still some mismatching behavior around `button` element. Differential Revision: https://phabricator.services.mozilla.com/D161537 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1799565 gecko-commit: 0f30447455dcbf2c99259f763a443f79fa521757 gecko-reviewers: smaug

…ly r=smaug Corresponds to the latest consensus and also matches what Chrome shipped behind `--enable-blink-features=SendMouseEventsDisabledFormControls`. Imported the portion of tests that is directly impacted here from web-platform-tests/wpt#32381. Others are not directly impacted and thus I'd like to land them separately since there are still some mismatching behavior around `button` element. Differential Revision: https://phabricator.services.mozilla.com/D161537

Corresponds to the latest consensus and also matches what Chrome shipped behind `--enable-blink-features=SendMouseEventsDisabledFormControls`. Imported the portion of tests that is directly impacted here from #32381. Others are not directly impacted and thus I'd like to land them separately since there are still some mismatching behavior around `button` element. Differential Revision: https://phabricator.services.mozilla.com/D161537 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1799565 gecko-commit: 0f30447455dcbf2c99259f763a443f79fa521757 gecko-reviewers: smaug

…ly r=smaug Corresponds to the latest consensus and also matches what Chrome shipped behind `--enable-blink-features=SendMouseEventsDisabledFormControls`. Imported the portion of tests that is directly impacted here from web-platform-tests/wpt#32381. Others are not directly impacted and thus I'd like to land them separately since there are still some mismatching behavior around `button` element. Differential Revision: https://phabricator.services.mozilla.com/D161537

jgraham mentioned this pull request Jan 14, 2022

[meta] Web Compat Bucket web-platform-tests/interop#9

Closed

jgraham force-pushed the event_propagate_disabled branch from d329515 to ef0f04c Compare January 14, 2022 12:26

jgraham force-pushed the event_propagate_disabled branch from ef0f04c to f6639da Compare January 14, 2022 14:56

jgraham marked this pull request as ready for review March 29, 2022 12:54

wpt-pr-bot added the html label Mar 29, 2022

wpt-pr-bot assigned foolip Mar 29, 2022

wpt-pr-bot requested review from annevk, domenic, foolip, jdm, tkent-google and zqzhang March 29, 2022 12:54

jgraham closed this Mar 29, 2022

jgraham reopened this Mar 29, 2022

moz-wptsync-bot added the mozilla:gecko-blocked label Mar 29, 2022

foolip requested changes Mar 30, 2022

View reviewed changes

html/semantics/forms/event-propagate-disabled.html Outdated Show resolved Hide resolved

html/semantics/forms/event-propagate-disabled.html Outdated Show resolved Hide resolved

jgraham force-pushed the event_propagate_disabled branch from f6639da to 74eae5c Compare March 31, 2022 16:31

jgraham force-pushed the event_propagate_disabled branch from 74eae5c to 9e2b476 Compare March 31, 2022 17:02

josepharhar reviewed Apr 7, 2022

View reviewed changes

html/semantics/forms/event-propagate-disabled.html Outdated Show resolved Hide resolved

saschanaz added 2 commits June 29, 2022 00:08

Merge remote-tracking branch 'origin/master' into event_propagate_dis…

48e36c0

…abled

test composedPath

d105971

saschanaz mentioned this pull request Jun 28, 2022

Add ways to disable experimental flags #34639

Merged

saschanaz added 5 commits July 1, 2022 02:50

add tests for disabling during immediate propagation

bed25d9

Flip the meaning of initialDisabled

eba1dac

Merge branch 'master' into event_propagate_disabled

73918a3

Create event-propagate-disabled-by-parent.html

315c8c4

fix regression

52b82f2

Subscribe submit event properly

5f04dbc

saschanaz added 3 commits July 8, 2022 16:43

Merge remote-tracking branch 'origin/master' into event_propagate_dis…

02da0df

…abled

add test for .target

579752c

Merge remote-tracking branch 'origin/master' into event_propagate_dis…

2c5624c

…abled

saschanaz marked this pull request as draft November 10, 2022 00:41

Update tests with the latest consensus

873c97f

moz-wptsync-bot mentioned this pull request Nov 11, 2022

[Gecko Bug 1799565] Allow pointer events on disabled form elements on Nightly #36933

Merged

Merge branch 'master' into event_propagate_disabled

e746fb2

saschanaz mentioned this pull request Nov 15, 2022

Pointer and mouse events web-platform-tests/interop#202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for event propagation on disabled form controls #32381

Add test for event propagation on disabled form controls #32381

jgraham commented Jan 14, 2022

jgraham commented Jan 14, 2022

foolip commented Mar 29, 2022

jgraham commented Mar 29, 2022

jgraham commented Mar 29, 2022

foolip commented Mar 30, 2022

saschanaz commented Mar 30, 2022 •

edited

jgraham commented Mar 30, 2022

saschanaz commented Mar 30, 2022

foolip commented Mar 30, 2022

jgraham commented Mar 31, 2022

josepharhar commented Apr 7, 2022

josepharhar commented Jun 28, 2022

saschanaz commented Jun 28, 2022

saschanaz commented Jul 5, 2022

jgraham commented Jul 6, 2022

saschanaz commented Jul 6, 2022 •

edited

saschanaz commented Jul 6, 2022

Add test for event propagation on disabled form controls #32381

Are you sure you want to change the base?

Add test for event propagation on disabled form controls #32381

Conversation

jgraham commented Jan 14, 2022

jgraham commented Jan 14, 2022

foolip commented Mar 29, 2022

jgraham commented Mar 29, 2022

jgraham commented Mar 29, 2022

foolip commented Mar 30, 2022

saschanaz commented Mar 30, 2022 • edited

jgraham commented Mar 30, 2022

saschanaz commented Mar 30, 2022

foolip commented Mar 30, 2022

jgraham commented Mar 31, 2022

josepharhar commented Apr 7, 2022

josepharhar commented Jun 28, 2022

saschanaz commented Jun 28, 2022

saschanaz commented Jul 5, 2022

jgraham commented Jul 6, 2022

saschanaz commented Jul 6, 2022 • edited

saschanaz commented Jul 6, 2022

saschanaz commented Mar 30, 2022 •

edited

saschanaz commented Jul 6, 2022 •

edited