testharness.js: fix shadow realm detection #33668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes shadow realm detection to not falsely discover the Deno main thread as a shadow realm. Because there is no reliable way to discover shadow realms in isolation, we add a a special global to inform testharness.js that it is running in a ShadowRealm.
|
Sorry again for the breakage--I had been hoping to avoid adding anything to the global object to signal the test environment is a ShadowRealm but it seems like it's probably the best way after all. Thanks :) |
Ms2ger
requested changes
Apr 19, 2022
Ms2ger
approved these changes
Apr 19, 2022
lucacasonato
added a commit
that referenced
this pull request
Apr 19, 2022
This reverts commit ce3cb95.
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Apr 27, 2022
This commit fixes shadow realm detection to not falsely discover the Deno main thread as a shadow realm. Because there is no reliable way to discover shadow realms in isolation, we add a a special global to inform testharness.js that it is running in a ShadowRealm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes shadow realm detection to not falsely discover the
Deno main thread as a shadow realm. Because there is no reliable way to
discover shadow realms in isolation, we add a a special global to inform
testharness.js that it is running in a ShadowRealm.
cc @jjgriego @Ms2ger