Add tests for RequestInit.duplex #34496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for whatwg/fetch#1457.
3 tasks
|
@annevk @lucacasonato PTAL |
annevk
reviewed
Jun 28, 2022
Comment on lines
-11
to
-14
| async function assert_request(test, input, init) { | ||
| assert_throws_js(TypeError, () => new Request(input, init), "new Request()"); | ||
| await promise_rejects_js(test, TypeError, fetch(input, init), "fetch()"); | ||
| } |
There was a problem hiding this comment.
Why remove this?
(If there's a good reason to remove this, presumably we don't need to use promise_test below?)
There was a problem hiding this comment.
If new Request(input, init) throws, then fetch(input, init) should be rejected. This is not at all streaming upload specific and I don't think we need to check that here.
Moreover, this is an HTTP/1.1 fetch, which is one more reason for fetch(input, init) to be rejected, which makes this assertion more pointless.
I turned some promise_tests into tests.
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Jul 1, 2022
Require a new duplex member to be set to "half" when request's body is a stream. This makes the semantics clearer for the caller and would allow for a better default in the future. Tests: web-platform-tests/wpt#34496. Closes #1438.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for whatwg/fetch#1457.