Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebDriver BiDi serialization: rename +Infinity to Infinity #34754

Merged
merged 1 commit into from
Jul 8, 2022
Merged

WebDriver BiDi serialization: rename +Infinity to Infinity #34754

merged 1 commit into from
Jul 8, 2022

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Jul 8, 2022 •
edited
Loading

Follow-up after updating BiDi spec: w3c/webdriver-bidi#254

@sadym-chromium sadym-chromium mentioned this pull request Jul 8, 2022
Merged
whimboo
whimboo approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I can see this covers every check for positive infinity. Thank you for updating the existing tests!

@foolip foolip merged commit 272182a into web-platform-tests:master Jul 8, 2022
@sadym-chromium sadym-chromium deleted the infinity branch July 12, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo approved these changes

@foolip foolip foolip approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@shs96c shs96c Awaiting requested review from shs96c

Assignees

@whimboo whimboo

Labels
webdriver-bidi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sadym-chromium @whimboo @foolip @juliandescottes @wpt-pr-bot @moz-wptsync-bot