fix(fetch): add missing duplex option #36268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Oct 5, 2022
|
This test is failing in every browser currently (see https://wpt.fyi/results/fetch/api/abort/general.any.html?label=experimental&label=master&aligned). With this patch, this is the output: |
|
any chance of having this merged? this is causing issues for us still |
annevk
force-pushed
the
missing-duplex-option
branch
from
8c8ad92
to
d7c6841
Compare
|
@KhafraDev thanks for the ping. I rebased this to see if we can get past the bots. I'm guessing browsers haven't started working on upload streams yet, but the logic here seems sound to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
duplex: 'half'option which caused test to reject with a TypeError rather than a DOMException.