Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements #37856

Merged
merged 1 commit into from Jan 12, 2023
Merged

Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements #37856

merged 1 commit into from Jan 12, 2023

Conversation

rniwa
Copy link
Contributor

@rniwa rniwa commented Jan 11, 2023

This is WPT updates for w3c/aria#1802

@cookiecrook cookiecrook mentioned this pull request Jan 11, 2023
Merged
1 task
annevk
annevk approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add a historical test that asserts ariaErrorMessageElement is not implemented.

@rniwa
Copy link
Contributor Author

rniwa commented Jan 11, 2023

I think it would be good to add a historical test that asserts ariaErrorMessageElement is not implemented.

Good point. Adding that.

@rniwa rniwa force-pushed the replace-ariaErrorMessageElement-with-ariaErrorMessageElements branch from 2c550ee to 2948659 Compare January 11, 2023 08:46
annevk
annevk approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rniwa rniwa force-pushed the replace-ariaErrorMessageElement-with-ariaErrorMessageElements branch from 2948659 to ce6f026 Compare January 11, 2023 08:52
mrego
mrego approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@mrego mrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the tests.

@rniwa rniwa merged commit b2408e7 into web-platform-tests:master Jan 12, 2023
@rniwa rniwa deleted the replace-ariaErrorMessageElement-with-ariaErrorMessageElements branch January 12, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrego mrego mrego approved these changes

@annevk annevk annevk approved these changes

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@hayatoito hayatoito Awaiting requested review from hayatoito

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@kojiishi kojiishi Awaiting requested review from kojiishi

@snuggs snuggs Awaiting requested review from snuggs

@TakayoshiKochi TakayoshiKochi Awaiting requested review from TakayoshiKochi

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@TakayoshiKochi TakayoshiKochi

Labels
custom-elements html wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rniwa @mrego @annevk @TakayoshiKochi @wpt-pr-bot