Test input element directionality is only submitted for text and search type #39664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch type This is in reference to the html issue [9206](whatwg/html#9206)
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
tkent-google and
zqzhang
Merged
4 tasks
|
See pull request for WHATWG HTML 9207 |
annevk
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Add coverage for textarea too?
Stretch goal: might also want to add coverage for new FormData(form).
Stretch goal 2: factor out the shared bits of scripts in this directory into a resources/dirname.js or some such and move dirname-ltr-iframe.html into that directory too.
|
Made the changes and simplified the shared parts a bit, I hope the commit is not too large. In the future, we could also test the textarea element in all other dirname test files. My suggestion is that I'll submit those changes when I get to implementing dirname on textarea in firefox. |
annevk
reviewed
Apr 26, 2023
html/semantics/forms/attributes-common-to-form-controls/resources/dirname.js
Outdated
Show resolved
Hide resolved
html/semantics/forms/attributes-common-to-form-controls/resources/dirname.js
Outdated
Show resolved
Hide resolved
annevk
reviewed
May 15, 2023
html/semantics/forms/attributes-common-to-form-controls/resources/dirname.js
Outdated
Show resolved
Hide resolved
annevk
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to html issue 9206
The standard currently does not enforce that for input elements, the directionality only applies for text and search types. I currently work on changing this and this pull request provides a test for the coming change.