Drop funcsigs (redux) #41292
Merged
Drop funcsigs (redux) #41292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.6+ is required to run Mach (and WPT), yet funcsigs was a backport for Python <3.3. Differential Revision: https://phabricator.services.mozilla.com/D146077 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1767822 gecko-commit: aabccf0d9d9076d45575b99a52b504867ab80328 gecko-reviewers: jgraham
Drop funcsigs Python 3.6+ is required to run Mach (and WPT), yet funcsigs was a backport for Python <3.3.
jgraham
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37150 tried to drop funcsigs, but this broke both WebKit and Servo importers, and this was reverted in #37442.
To quote #37442 (comment):
This re-lands #37150 and additionally deletes the entirety of
tools/third_party/funcsigs(including the broken symlink).I've confirmed the WebKit importer continues to work with this landed; I have not tried the Servo importer (cc @jdm).
(We should make sure we squash this prior to landing, but this sequence of commits makes it clear what's changed since we previously landed it for review purposes.)