HTML: tests for <input type=checkbox switch> #42449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
cookiecrook
reviewed
Oct 11, 2023
This was referenced Oct 11, 2023
cookiecrook
reviewed
Oct 13, 2023
annevk
force-pushed
the
annevk/switch-control
branch
from
43e795f
to
0f61c29
Compare
nt1m
reviewed
Nov 3, 2023
html/semantics/selectors/pseudo-classes/indeterminate-switch.indeterminate.window.js
Outdated
Show resolved
Hide resolved
For whatwg/html#9546. Co-authored-by: lilyspiniolas <119537181+lilyspiniolas@users.noreply.github.com>
annevk
force-pushed
the
annevk/switch-control
branch
from
0f61c29
to
4b7d036
Compare
nt1m
reviewed
Nov 3, 2023
Comment on lines
42
to
46
| assert_true(body.matches(":has(:indeterminate)")); | ||
|
|
||
| input.switch = true; | ||
| assert_false(body.matches(":has(:indeterminate)")); | ||
| }, "Parent of a checkbox that becomes a switch control does not match :has(:indeterminate)"); |
There was a problem hiding this comment.
Testing style invalidation (not just matching) in a separate commit like css/selectors/invalidation/input-pseudo-classes-in-has.html would be valuable. Having the styling stay stale is a common issue with :has()
There was a problem hiding this comment.
css/selectors/invalidation/media-pseudo-classes-in-has.html is another good example to go off
There was a problem hiding this comment.
That would have been nice to know an hour ago. I think this can be a follow-up.
nt1m
approved these changes
Nov 3, 2023
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Nov 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=264129 rdar://117885150 Reviewed by Tim Nguyen. This hopefully ensures that the logic added to HTMLInputElement does not regress. The added tests are upstreamed via web-platform-tests/wpt#42449. They are .tentative for now as standardization is still ongoing. * LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-dynamic-switch.tentative.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-dynamic-switch.tentative.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-dynamic-switch.tentative.window.js: Added. (promise_test.async t): * LayoutTests/imported/w3c/web-platform-tests/html-aam/roles.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html-aam/roles.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-indeterminate-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-indeterminate.tentative-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-indeterminate.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-notref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch.tentative-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch.tentative-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch.tentative.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch.tentative.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch.tentative.window.js: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/input-checkbox-switch.tentative.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/input-checkbox-switch.tentative.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/input-checkbox-switch.tentative.window.js: Added. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/270176@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#9546.