WebKit export of https://bugs.webkit.org/show_bug.cgi?id=266384 #43678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+. |
wpt-pr-bot
approved these changes
Dec 15, 2023
cookiecrook
requested changes
Dec 15, 2023
There was a problem hiding this comment.
FYI this isn't going to land. Even though Gecko doesn't yet support element reflection, it does support the fallback misspelling. Since there is full interop of the attribute misspelling, and usage is low but not insignificant, we should keep support for the alternate spelling. I'll file an issue in ARIA to make sure this is documented, along with conflict precedence, and fallback/conflict tests are added to WPT: e.g. aria-labelledby should obviously win over aria-labeledby but should the misspelled aria-labeledby win over aria-label? I think more info is needed to determine that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description added by @cookiecrook
This reverts a bogus portion of 3a5dc6a
…that included a purposeful misspelling "aria-labeledby" of "aria-labelledby" which both WebKit and Chrome supported, but was never documented or specified...
FWIW, the original file also seems like a bad test structure to me, since most subtests include more than one assertion. For example, it's unclear from the test results if Gecko fails this test because it (correctly?) does not support the missspelling, or because it fails one of the other assertions in this subtest.
I'm going to spawn several other issues to address those discrepancies. - jc