Add tests for the writingsuggestions attribute #43780

sanketj · 2023-12-22T22:30:41Z

whatwg/html#9065 proposes the introduction of a new attribute to control UA-provided writing assistance. This PR adds WPT test coverage for that attribute.

Corresponding spec PR: whatwg/html#10018

marcoscaceres

These are really thorough! Was great to see.

marcoscaceres · 2024-01-17T21:53:28Z

Only nit is the formatting... could maybe run prettier over js tests, but no big deal if not.

stephanieyzhang · 2024-02-06T07:50:54Z

Some of the getAttribute checks may need to be modified to align with the default behavior of missing/invalid content attributes. The content attributes are not affected by inheritance e.g.:

If 'writingSuggestions' is missing on the element, then element..getAttribute('writingSuggestions') == null, regardless of its parents' attributes.
If 'writingSuggestions' is set to an empty string, then element.getAttribute('writingSuggestions') == '', regardless of its parents' attributes.

This aligns with the content attribute behavior of the 'spellcheck' attribute, which 'writingSuggestions' shares a lot of similarities with. cc: @dandclark

This CL implements the new 'writingSuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements if specified; otherwise, it default to "true". Changes were verified against wpt tests: #43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c

This CL implements the new 'writingSuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements if specified; otherwise, it default to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) #43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c

This CL implements the new 'writingSuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements if specified; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) #43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c

annevk

I'm missing coverage for:

input types to which the attribute does not apply.
Elements that are disabled.

dandclark · 2024-02-09T18:39:40Z

I'm missing coverage for:

input types to which the attribute does not apply.

Elements that are disabled.

To be clear -- the attribute setting/getting/reflection behavior that's validated in this test would be the same for those elements. The spec's checks for disabled and non-applicable input types only applies to the steps determining whether the user agent actually applies the suggestions or not.

But, still a good idea to have these tests to verify that the attribute setting/getting/reflection behavior is no different.

This CL implements the new 'writingSuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) #43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c

This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) #43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c

This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) #43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247315 Reviewed-by: Dan Clark <daniec@microsoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1259389}

…stonly Automatic update from web-platform-tests Add 'writingsuggestions' attribute This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) web-platform-tests/wpt#43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247315 Reviewed-by: Dan Clark <daniec@microsoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1259389} -- wpt-commits: dbbfe1b6f0efc3b68ce5d59bdb0c36b3dd615c86 wpt-pr: 44413

input types This CL adds tests for disabled elements and input types to which writing suggestions are not applicable (eg <input type="color"/>). The 'writingsuggestions' attribute setting/getting/reflection behavior for these types of elements is identical to that of elements on which writing suggestions should be generated. The User Agent is responsible for ensuring that writing suggestions aren't applied to these types of elements. github.com//pull/43780#issuecomment-1936426092 Bug: 1513953 Change-Id: I31aa03b131ab440d5d6e749c227837997f13464c

…stonly Automatic update from web-platform-tests Add 'writingsuggestions' attribute This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) web-platform-tests/wpt#43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247315 Reviewed-by: Dan Clark <daniecmicrosoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhangmicrosoft.com> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1259389} -- wpt-commits: dbbfe1b6f0efc3b68ce5d59bdb0c36b3dd615c86 wpt-pr: 44413 UltraBlame original commit: c25909ad3c081dfe228692bab7ecddc4c087a642

input types This CL adds tests for disabled elements and input types to which writing suggestions are not applicable (eg <input type="color"/>). The 'writingsuggestions' attribute setting/getting/reflection behavior for these types of elements is identical to that of elements on which writing suggestions should be generated. The User Agent is responsible for ensuring that writing suggestions aren't applied to these types of elements. github.com//pull/43780#issuecomment-1936426092 Bug: 1513953 Change-Id: I31aa03b131ab440d5d6e749c227837997f13464c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5299628 Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1261510}

…stonly Automatic update from web-platform-tests Add 'writingsuggestions' attribute This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) web-platform-tests/wpt#43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247315 Reviewed-by: Dan Clark <daniecmicrosoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhangmicrosoft.com> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1259389} -- wpt-commits: dbbfe1b6f0efc3b68ce5d59bdb0c36b3dd615c86 wpt-pr: 44413 UltraBlame original commit: c25909ad3c081dfe228692bab7ecddc4c087a642

…stonly Automatic update from web-platform-tests Add 'writingsuggestions' attribute This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) web-platform-tests/wpt#43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247315 Reviewed-by: Dan Clark <daniec@microsoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1259389} -- wpt-commits: dbbfe1b6f0efc3b68ce5d59bdb0c36b3dd615c86 wpt-pr: 44413

stephanieyzhang · 2024-02-23T00:18:50Z

Hi all, we've recently updated these tests as part of our implementation in Chromium. The tests include coverage for disabled elements and input types where writing suggestions are not applicable. Since there hasn't been a resolute decision about what the attribute should return for these cases, we've aligned the behavior with other elements where writing suggestions are applicable. If there are any changes to this behavior in the future, I'll provide updated tests. Thanks!

…led elements and "unsupported" input types, a=testonly Automatic update from web-platform-tests Add 'writingsuggestions' tests for disabled elements and "unsupported" input types This CL adds tests for disabled elements and input types to which writing suggestions are not applicable (eg <input type="color"/>). The 'writingsuggestions' attribute setting/getting/reflection behavior for these types of elements is identical to that of elements on which writing suggestions should be generated. The User Agent is responsible for ensuring that writing suggestions aren't applied to these types of elements. github.com/web-platform-tests/wpt/pull/43780#issuecomment-1936426092 Bug: 1513953 Change-Id: I31aa03b131ab440d5d6e749c227837997f13464c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5299628 Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1261510} -- wpt-commits: f6f118de16681fc1586f265c2ea7bea98fc7dec9 wpt-pr: 44613

This CL implements the new 'writingsuggestions' attribute. We add a new runtime flag and setter/getter methods for it. The attribute has values "true"/"false" to allow developers to enable or disable browser-provided writing suggestions. If the attribute is not explicitly set on an element, it inherits its value from ancestor elements; otherwise, it defaults to "true". Changes were verified against wpt tests: (note: checks for getAttribute() for missing/invalid attributes differ to align with default behavior) #43780 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE Bug: 1513953 Change-Id: I716deba02f3d8df37dd04d1363d624cf2615203c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247315 Reviewed-by: Dan Clark <daniec@microsoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1259389}

input types This CL adds tests for disabled elements and input types to which writing suggestions are not applicable (eg <input type="color"/>). The 'writingsuggestions' attribute setting/getting/reflection behavior for these types of elements is identical to that of elements on which writing suggestions should be generated. The User Agent is responsible for ensuring that writing suggestions aren't applied to these types of elements. github.com//pull/43780#issuecomment-1936426092 Bug: 1513953 Change-Id: I31aa03b131ab440d5d6e749c227837997f13464c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5299628 Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1261510}

…led elements and "unsupported" input types, a=testonly Automatic update from web-platform-tests Add 'writingsuggestions' tests for disabled elements and "unsupported" input types This CL adds tests for disabled elements and input types to which writing suggestions are not applicable (eg <input type="color"/>). The 'writingsuggestions' attribute setting/getting/reflection behavior for these types of elements is identical to that of elements on which writing suggestions should be generated. The User Agent is responsible for ensuring that writing suggestions aren't applied to these types of elements. github.com/web-platform-tests/wpt/pull/43780#issuecomment-1936426092 Bug: 1513953 Change-Id: I31aa03b131ab440d5d6e749c227837997f13464c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5299628 Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1261510} -- wpt-commits: f6f118de16681fc1586f265c2ea7bea98fc7dec9 wpt-pr: 44613

sanketj · 2024-03-13T05:33:07Z

As mentioned in this comment, tests for the writingsuggestions attribute were added as part of implementing in Chromium and those have been merged into WPT here. Abandoning this PR accordingly.

sanketj added 2 commits December 22, 2023 13:29

Add WPT tests for the writingsuggestions attribute.

e85f717

Fix typo

28b4517

wpt-pr-bot added the html label Dec 22, 2023

wpt-pr-bot assigned annevk Dec 22, 2023

wpt-pr-bot requested review from annevk, domenic, foolip, jdm and jgraham December 22, 2023 22:30

sanketj mentioned this pull request Dec 22, 2023

Add a new attribute called writingsuggestions to control UA-provided writing assistance whatwg/html#10018

Merged

5 tasks

sanketj changed the title ~~[writingsuggestions] Add tests for the writingsuggestions attribute~~ Add tests for the writingsuggestions attribute Dec 22, 2023

sanketj mentioned this pull request Dec 23, 2023

New attribute to control UA-provided writing assistance w3ctag/design-reviews#924

Closed

1 task

Update writingsuggestions WPT tests to reflect latest spec PR changes.

cb00477

marcoscaceres approved these changes Jan 17, 2024

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Feb 6, 2024

Add 'writingsuggestions' attribute #44413

Merged

annevk reviewed Feb 9, 2024

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Feb 15, 2024

Add 'writingsuggestions' tests for disabled elements and "unsupported" input types #44613

Merged

sanketj closed this Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for the writingsuggestions attribute #43780

Add tests for the writingsuggestions attribute #43780

sanketj commented Dec 22, 2023 •

edited

marcoscaceres left a comment

marcoscaceres commented Jan 17, 2024

stephanieyzhang commented Feb 6, 2024 •

edited

annevk left a comment

dandclark commented Feb 9, 2024

stephanieyzhang commented Feb 23, 2024 •

edited

sanketj commented Mar 13, 2024

Add tests for the writingsuggestions attribute #43780

Add tests for the writingsuggestions attribute #43780

Conversation

sanketj commented Dec 22, 2023 • edited

marcoscaceres left a comment

Choose a reason for hiding this comment

marcoscaceres commented Jan 17, 2024

stephanieyzhang commented Feb 6, 2024 • edited

annevk left a comment

Choose a reason for hiding this comment

dandclark commented Feb 9, 2024

stephanieyzhang commented Feb 23, 2024 • edited

sanketj commented Mar 13, 2024

sanketj commented Dec 22, 2023 •

edited

stephanieyzhang commented Feb 6, 2024 •

edited

stephanieyzhang commented Feb 23, 2024 •

edited