Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebDriver BiDi] Add tests for browsingContext.close for promptUnload #44004

Merged
merged 11 commits into from
Jun 26, 2024

Conversation

Lightning00Blade
Copy link
Contributor

Add the scaffolding and test for browsingContext.close for parameter promptUnload.
PR does not cover testing subframes that have beforeunload handlers (feature PR).

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

@OrKoN
Copy link
Contributor

OrKoN commented Jan 16, 2024

@Lightning00Blade is it expected to pass for the Chrome version in wpt.fyi?

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the remaining failures. It looks fine to me now. Just a small nit inline, but fine for landing anyway. Thank you as well for working on these tests!

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/VonxttWRQh6OfacJqQ--Iw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/VonxttWRQh6OfacJqQ--Iw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-06-25T14:00:31.561Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/TDRtIAueRqOEQxBa1wzZNw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/TDRtIAueRqOEQxBa1wzZNw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-06-25T14:00:31.675Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/TDRtIAueRqOEQxBa1wzZNw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/TDRtIAueRqOEQxBa1wzZNw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-06-25T14:00:35.228Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/VonxttWRQh6OfacJqQ--Iw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/VonxttWRQh6OfacJqQ--Iw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-06-25T14:00:44.745Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/TDRtIAueRqOEQxBa1wzZNw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ/TDRtIAueRqOEQxBa1wzZNw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/EVj_5OSvTz-AUAzGkRNMAQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-06-25T14:54:59.915Z

@whimboo
Copy link
Contributor

whimboo commented Jun 26, 2024

@Lightning00Blade as it looks like Chrome is timing out on the prompt_unload.py file. Could it be that there is a very slow startup or is it timing out while waiting for an event?

@Lightning00Blade
Copy link
Contributor Author

@whimboo it's issue on our end, we can merge this as is.

@Lightning00Blade Lightning00Blade merged commit 2d15bea into master Jun 26, 2024
42 of 43 checks passed
@Lightning00Blade Lightning00Blade deleted the add-bidi-prompt-unload-test branch June 26, 2024 07:51
sadym-chromium pushed a commit that referenced this pull request Jul 18, 2024
…oad` (#44004)

* [WebDriver BiDi] Add tests for `browsingContext.close` for `promptUnload`

* fix

* chore: address comments

* chore: add more tests

* chore: add safe to prevent file timeouts

* chore: listen if the event is emitted

* chore: fix python

* chore: simplify

* chore: fix

* Update webdriver/tests/bidi/browsing_context/close/prompt_unload.py

Co-authored-by: Henrik Skupin <mail@hskupin.info>

* chore: format

---------

Co-authored-by: Henrik Skupin <mail@hskupin.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants