Improve reflected attribute tests (html/dom/reflection.js) #44355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a toString:null in test values that are objects
with a valueOf method, the DOM attribute would actually
be set to "[object Object]" without ever calling the
valueOf method (effectively turning those tests into
behaving exactly the same as the {"test": 6} ones).
Most existing tests were passing because the implemented
algorithms would actually compute a WRONG expected value.
The only test that doesn't compute the expected value
("double") won't actually run because all reflected IDL
attributes of type "double" have custom getters.
Fixes web-platform-tests#44315
Setting -0 to the IDL attribute will set the DOM attribute to "0" (per ECMAScript's ToString, from the rules for the the best representation of a number as a floating point number), and the rules for parsing flowting-point number values won't ever turn that "0" into a -0 value. This test value is never actually being used though, as all the reflected attributes of type "double" have custom getters.
|
Various improvements, each in its own commit. Let me know if you'd prefer separate PRs. |
tbroyer
commented
Feb 2, 2024
Specifically leading non-ASCII whitespace following leading ASCII whitespace (should be rejected), and trailing non-ASCII whitespace (should be ignored)
Specifically "+" and "-" to exercise all possible code paths of failures.
|
I ran the tests with coverage (a copy, in a different project that reuses them), which led me to add a few tests (including exponential notation) and revealed a bug in the PR updated with the new tests and fixed harness. |
zcorpan
requested changes
Feb 5, 2024
This should make it easier to extend tests with more values.
zcorpan
approved these changes
Feb 6, 2024
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 13, 2024
…ive values on setting. r=dom-core,edgar Tests will be in WPT (web-platform-tests/wpt#44355) Differential Revision: https://phabricator.services.mozilla.com/D200619
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 15, 2024
…ive values on setting. r=dom-core,edgar Tests will be in WPT (web-platform-tests/wpt#44355) Differential Revision: https://phabricator.services.mozilla.com/D200619
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Feb 16, 2024
…ive values on setting. r=dom-core,edgar Tests will be in WPT (web-platform-tests/wpt#44355) Differential Revision: https://phabricator.services.mozilla.com/D200619 UltraBlame original commit: e62f150c6ffe94380dd9cd83d6058143065dea2c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Feb 20, 2024
…ive values on setting. r=dom-core,edgar Tests will be in WPT (web-platform-tests/wpt#44355) Differential Revision: https://phabricator.services.mozilla.com/D200619 UltraBlame original commit: e62f150c6ffe94380dd9cd83d6058143065dea2c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44315