Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that appcache is not supported in shared workers #5001

Merged
merged 2 commits into from
Feb 24, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>AppCache should not exist in shared workers, even though it was specced at some point</title>
<link rel="help" href="https://github.com/whatwg/html/pull/2384">
<link rel="author" title="Domenic Denicola" href="mailto:d@domenic.me">

<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>

<script>
"use strict";

if (typeof SharedWorker === "undefined") {
test(() => {
assert_equals(typeof SharedWorker, "undefined");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the outer if, I think no assertion at all here would be clearer.

}, "This browser doesn't implement SharedWorker, and so passes this test automatically");
} else {
fetch_tests_from_worker(new SharedWorker("no-appcache-in-shared-workers-historical.js"));
}
</script>
14 changes: 14 additions & 0 deletions html/browsers/offline/no-appcache-in-shared-workers-historical.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
"use strict";
self.importScripts('/resources/testharness.js');

test(() => {
assert_equals(self.applicationCache, undefined, "self.applicationCache must be undefined");
assert_false("applicationCache" in self, "applicationCache must not even be a property of self");
}, "self.applicationCache must not exist");

test(() => {
assert_equals(self.ApplicationCache, undefined, "self.ApplicationCache must be undefined");
assert_false("ApplicationCache" in self, "ApplicationCache must not even be a property of self");
}, "ApplicationCache must not be exposed");

done();