Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that appcache is not supported in shared workers #5001

Merged
merged 2 commits into from Feb 24, 2017

Conversation

@domenic
Copy link
Member

@domenic domenic commented Feb 23, 2017

Follows whatwg/html#2384.

@wpt-pr-bot
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot commented Feb 23, 2017

@w3c-bots
Copy link

@w3c-bots w3c-bots commented Feb 23, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 64672af45377a4efa2a6cf1bc368c37acc0678dd
Using browser at version BuildID 20170223110219; SourceStamp 32dcdde1fc64fc39a9065dc4218265dbc727673f
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/offline/no-appcache-in-shared-workers-historical.html
Subtest Results
OK
self.applicationCache must not exist PASS
ApplicationCache must not be exposed PASS

@w3c-bots
Copy link

@w3c-bots w3c-bots commented Feb 23, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 64672af45377a4efa2a6cf1bc368c37acc0678dd
Using browser at version 58.0.3018.3 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/offline/no-appcache-in-shared-workers-historical.html
Subtest Results
OK
self.applicationCache must not exist PASS
ApplicationCache must not be exposed PASS

foolip
foolip approved these changes Feb 24, 2017

if (typeof SharedWorker === "undefined") {
test(() => {
assert_equals(typeof SharedWorker, "undefined");
Copy link
Member

@foolip foolip Feb 24, 2017

Given the outer if, I think no assertion at all here would be clearer.

@foolip foolip merged commit 771007a into master Feb 24, 2017
2 checks passed
@foolip foolip deleted the no-appcache-in-shared-workers branch Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants