Rewrite video_{009,010}.htm as reftests. #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use a smaller poster image to accommodate smaller screens.
|
Critic review: https://critic.hoppipolla.co.uk/r/554 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Ms2ger
added a commit
that referenced
this pull request
Jan 15, 2014
Rewrite video_{009,010}.htm as reftests; r=denis
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 26, 2018
According to below linked issue(#514), CSSVariableReferenceValue should have a constructor. and also fallback attribute should be readonly attribute. constructor was already added in chromium. but readonly keyword was not added. so add readonly keyword for fallback attribute. (actually it is related with #513 to add readonly keyword) w3c/css-houdini-drafts#547 w3c/css-houdini-drafts#514 w3c/css-houdini-drafts#513 Bug: 803687 Change-Id: I91b5d4f21b75cd5d27063bfceba0b39b30977be9
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 27, 2018
According to below linked issue(#514), CSSVariableReferenceValue should have a constructor. and also fallback attribute should be readonly attribute. constructor was already added in chromium. but readonly keyword was not added. so add readonly keyword for fallback attribute. (actually it is related with #513 to add readonly keyword) w3c/css-houdini-drafts#547 w3c/css-houdini-drafts#514 w3c/css-houdini-drafts#513 Bug: 803687 Change-Id: I91b5d4f21b75cd5d27063bfceba0b39b30977be9 Reviewed-on: https://chromium-review.googlesource.com/881381 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#532167}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 27, 2018
According to below linked issue(#514), CSSVariableReferenceValue should have a constructor. and also fallback attribute should be readonly attribute. constructor was already added in chromium. but readonly keyword was not added. so add readonly keyword for fallback attribute. (actually it is related with #513 to add readonly keyword) w3c/css-houdini-drafts#547 w3c/css-houdini-drafts#514 w3c/css-houdini-drafts#513 Bug: 803687 Change-Id: I91b5d4f21b75cd5d27063bfceba0b39b30977be9 Reviewed-on: https://chromium-review.googlesource.com/881381 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#532167}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use a smaller poster image to accommodate smaller screens.