Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-elements: Fix a bug that HTML parser didn't set custom element state correctly for unknown "is" attribute value. #9405

Merged
merged 1 commit into from
Feb 6, 2018

Commits on Feb 6, 2018

  1. custom-elements: Fix a bug that HTML parser didn't set custom element…

    … state correctly for unknown "is" attribute value.
    
    In HTML parser, if custom element definition is not found and the
    element local name is invalid for custom element name, custom element
    state of the element was set to "Uncustomized", which won't be upgraded.
    
    It should be "Undefined" if "is" attribute exists.
    
    Also, CustomElementRegistry::AddCandidate() didn't pick up a correct
    name for customized built-in candidates.
    
    A Blink layout test for :defined is upstreamed to WPT.
    
    Bug: 736967
    Change-Id: I583073eabc4ac276c6990161516c7b289905909b
    Reviewed-on: https://chromium-review.googlesource.com/903423
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#534621}
    tkent-google authored and chromium-wpt-export-bot committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    4fc2724 View commit details
    Browse the repository at this point in the history