Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending empty messages #5

Closed
marco-c opened this issue Sep 28, 2015 · 1 comment
Closed

Support sending empty messages #5

marco-c opened this issue Sep 28, 2015 · 1 comment

Comments

@marco-c
Copy link
Member

marco-c commented Sep 28, 2015

Make sure the implementation works with empty messages.

There's a distinction between notifications without a message and notifications with an empty message:
mozilla-services/autopush#132 (comment)
w3c/push-api#161

@marco-c marco-c closed this as completed in 842f3b7 Oct 1, 2015
@marco-c
Copy link
Member Author

marco-c commented Oct 1, 2015

Sending an empty message works correctly, I've tested it in https://github.com/marco-c/tictactoe/.
So in 842f3b7 I've added a unit test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant