Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dag-ucan, types and names #90

Merged
merged 12 commits into from
Sep 14, 2022
Merged

fix: update dag-ucan, types and names #90

merged 12 commits into from
Sep 14, 2022

Conversation

hugomrdias
Copy link
Contributor

depends on ipld/js-dag-ucan#55

Gozala
Gozala requested changes Sep 9, 2022
View reviewed changes
.github/release-please-manifest.json
@@ -1 +1,9 @@
{"packages/authority":"0.5.0","packages/client":"0.6.0","packages/core":"0.6.0","packages/interface":"0.7.0","packages/server":"0.7.0","packages/transport":"0.7.0","packages/validator":"0.6.0"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably ignore this file because release-please insists on not touching it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe im not familiar with your setup here

packages/authority/package.json Outdated Show resolved Hide resolved
packages/authority/test/lib.spec.js Outdated Show resolved Hide resolved
packages/client/test/client.spec.js Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/validator/src/decoder/link.js Outdated
@@ -11,7 +11,7 @@ export { create, createV0, isLink, asLink, parse }
* @template {1|0} Version
* @param {unknown} input
* @param {{code?:Code, algorithm?:Alg, version?:Version}} [options]
* @returns {API.Result<API.Link<unknown, Code, Alg, Version>, API.Failure>}
* @returns {API.Result<API.Link<any, Alg>, API.Failure>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @returns {API.Result<API.Link<any, Alg>, API.Failure>}
* @returns {API.Result<API.Link<unknown, Alg>, API.Failure>}

packages/validator/src/decoder/link.js Outdated
@@ -43,7 +43,7 @@ export const decode = (input, options = {}) => {
)
}

/** @type {API.Link<unknown, Code, Alg, Version>} */
/** @type {API.Link<any, Alg>} */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** @type {API.Link<any, Alg>} */
/** @type {API.Link<unknown, Alg>} */

packages/validator/src/decoder/link.js Outdated
@@ -56,7 +56,7 @@ export const decode = (input, options = {}) => {
* @template {number} Alg
* @template {1|0} Version
* @param {{code?:Code, algorithm?:Alg, version?:Version}} options
* @returns {API.Decoder<unknown, API.Link<unknown, Code, Alg, Version>, API.Failure>}
* @returns {API.Decoder<unknown, API.Link<any, Alg>, API.Failure>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @returns {API.Decoder<unknown, API.Link<any, Alg>, API.Failure>}
* @returns {API.Decoder<unknown, API.Link<unknown, Alg>, API.Failure>}

packages/validator/src/decoder/link.js Outdated
@@ -68,7 +68,7 @@ export const match = (options) => ({
* @template {number} Alg
* @template {1|0} Version
* @param {{code?:Code, algorithm?:Alg, version?:Version}} [options]
* @returns {API.Decoder<unknown, undefined|API.Link<unknown, Code, Alg, Version>, API.Failure>}
* @returns {API.Decoder<unknown, undefined|API.Link<any,Alg>, API.Failure>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @returns {API.Decoder<unknown, undefined|API.Link<any,Alg>, API.Failure>}
* @returns {API.Decoder<unknown, undefined|API.Link<unknown, Alg>, API.Failure>}

packages/validator/src/decoder/uri.js Show resolved Hide resolved
@Gozala
Copy link
Collaborator

Gozala commented Sep 14, 2022

@hugomrdias I have addressed all the remaining issues & fixed few type regressions I've discovered. I also have reflected new agreed naming of Principal and SigningPrincipal. Can you please take a look & if it looks good feel free to merge & release.

Only think that I'm not sure about is why in some places @template Service changed into @template {Record<string, any>} Service is that necessary ? If so would be good to put a comment explaining why.

hugomrdias
hugomrdias commented Sep 14, 2022
View reviewed changes
Copy link
Contributor Author

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really think we should keep the UCAN namespace in the type exports since have a few types with the same name in UCAN and Ucanto

packages/interface/src/principal.ts Show resolved Hide resolved
packages/interface/src/transport.ts Show resolved Hide resolved
packages/interface/src/lib.ts Show resolved Hide resolved
@hugomrdias @Gozala
Update packages/interface/src/lib.ts
c14423f 
Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
@Gozala Gozala merged commit cd792c9 into main Sep 14, 2022
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Merged
@Gozala Gozala mentioned this pull request Dec 2, 2022
Merged
This was referenced Dec 14, 2022
Merged
Merged
This was referenced Apr 11, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gozala Gozala Gozala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @Gozala