feat: add name to w3 space info output
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seemed odd that I have to use `w3 space ls` and scan the list to find the `*` to find the name of the currently selected space. This fixes it so that `w3 space info` includes the name where possible. The `space/info` capability doesn't provide the meta.name field of a space but perhaps it should. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
approved these changes
Jan 23, 2024
vasco-santos
approved these changes
Jan 23, 2024
alanshaw
pushed a commit
that referenced
this pull request
Jan 23, 2024
🤖 I have created a release *beep* *boop* --- ## [7.3.0](v7.2.1...v7.3.0) (2024-01-23) ### Features * add `name` to `w3 space info` output ([#164](#164)) ([2b1bc4a](2b1bc4a)) ### Bug Fixes * clear timeout always ([#166](#166)) ([c1b7cce](c1b7cce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed odd that I have to use
w3 space lsand scan the list to find the*to find the name of the currently selected space.This fixes it so that
w3 space infoincludes the name where possible.The
space/infocapability doesn't provide the meta.name field of a space but perhaps it should.License: MIT