Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proof add command #24

Merged
merged 3 commits into from
Dec 13, 2022
Merged

feat: add proof add command #24

merged 3 commits into from
Dec 13, 2022

Conversation

alanshaw
Copy link
Member

Similar to space add but doesn't also add the proof to your list of spaces.

README.md Outdated
@@ -131,6 +131,8 @@ List delegations created by this agent for others.

### `w3 proof add <proof.ucan>`

Add a proof delegated to this agent. The proof is a CAR encoded delegation to _this_ agent. Note: use `w3 space add` to add a proof _as well as_ add the resource to your list of spaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: I could use some more educating here... My understanding is that a space proof is a specific kind of proof that delegates capabilities over the with which is a special did:key that has been registered as a "space" with w3s, or will be in the future.

So "some proofs grant abilities on a space and some don't"... Or do we see any with in a proof as potentially being a "space" and so "all proofs grant abilities over a space".

If it's the former we should tweak the wording to say more like "you probably want space add unless you know the delegation you received targets something other than a w3 space"

Copy link
Member Author

@alanshaw alanshaw Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the difference you explained but I agree that we want to add "you probably want space add unless you know the delegation you received targets a resource other than a w3 space".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the with in a proof always gonna be considered a "space" in our world, or does the with sometimes point to a thing that is not a space?

@alanshaw alanshaw merged commit eb32d28 into main Dec 13, 2022
@alanshaw alanshaw deleted the feat/proof-add branch December 13, 2022 09:36
alanshaw pushed a commit that referenced this pull request Dec 14, 2022
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2022-12-14)


### Features

* add `list` command
([#10](#10))
([b6cb1f0](b6cb1f0))
* add `proof add` command
([#24](#24))
([eb32d28](eb32d28))
* add `space` command with `create` and `register`
([#3](#3))
([9c25a2d](9c25a2d))
* add `w3 can store add` and `w3 can upload add` commands
([#26](#26))
([07fa1b0](07fa1b0))
* add `whoami` to print agent DID
([#11](#11))
([e3f2497](e3f2497))
* add delegation create command
([#5](#5))
([272c53a](272c53a))
* add old CLI bin reference
([#4](#4))
([9a0716c](9a0716c))
* delegation ls and proof ls commands
([#22](#22))
([04a7d31](04a7d31))
* sade cli skeleton
([#1](#1))
([3104b9f](3104b9f))
* up command ([#7](#7))
([283b938](283b938))


### Bug Fixes

* add expiration parameter
([#21](#21))
([9457841](9457841))
* better error reporting
([#19](#19))
([0f6a2a6](0f6a2a6)),
closes [#15](#15)
[#16](#16)
* create space on register
([#13](#13))
([f4a1a0f](f4a1a0f))
* dont emit warnings for fetch api
([#9](#9))
([cf52922](cf52922))
* files-from-path with common path prefix removed
([#27](#27))
([c849d8e](c849d8e))
* no build
([72b0bfb](72b0bfb))
* no-wrap parameter
([#25](#25))
([38aa353](38aa353)),
closes [#17](#17)
* space create and register improvements
([#8](#8))
([8617b49](8617b49))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants