fix: no-wrap parameter #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olizilla
reviewed
Dec 13, 2022
| // @ts-ignore | ||
| const root = await client.uploadDirectory(files, { | ||
| /** @type {(o?: import('@web3-storage/w3up-client/src/types').UploadOptions) => Promise<import('@web3-storage/w3up-client/src/types').AnyLink>} */ | ||
| const uploadFn = files.length === 1 && opts['no-wrap'] |
There was a problem hiding this comment.
i think files.length would be > 1 if you added
foo
├── alan.txt
└── bar.txt
is it that directories are always wrapped so the foo is preserved?
we should warn the user that --no-wrap is ignored in that case, or error
There was a problem hiding this comment.
Ah, files-from-path is relative to working directory, not common path...
There was a problem hiding this comment.
I think this is the fix #27
|
is this related to our ability to hide the directory selection stuff from users? storacha/w3ui#139 |
|
This is "when encoding a file to unixfs; should we create a directory for you with that single thing in it to preserve your things filename in the dag". If we don't then you are gonna get a CID for the bytes of your file, but your filename is not captured. |
alanshaw
pushed a commit
that referenced
this pull request
Dec 14, 2022
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2022-12-14) ### Features * add `list` command ([#10](#10)) ([b6cb1f0](b6cb1f0)) * add `proof add` command ([#24](#24)) ([eb32d28](eb32d28)) * add `space` command with `create` and `register` ([#3](#3)) ([9c25a2d](9c25a2d)) * add `w3 can store add` and `w3 can upload add` commands ([#26](#26)) ([07fa1b0](07fa1b0)) * add `whoami` to print agent DID ([#11](#11)) ([e3f2497](e3f2497)) * add delegation create command ([#5](#5)) ([272c53a](272c53a)) * add old CLI bin reference ([#4](#4)) ([9a0716c](9a0716c)) * delegation ls and proof ls commands ([#22](#22)) ([04a7d31](04a7d31)) * sade cli skeleton ([#1](#1)) ([3104b9f](3104b9f)) * up command ([#7](#7)) ([283b938](283b938)) ### Bug Fixes * add expiration parameter ([#21](#21)) ([9457841](9457841)) * better error reporting ([#19](#19)) ([0f6a2a6](0f6a2a6)), closes [#15](#15) [#16](#16) * create space on register ([#13](#13)) ([f4a1a0f](f4a1a0f)) * dont emit warnings for fetch api ([#9](#9)) ([cf52922](cf52922)) * files-from-path with common path prefix removed ([#27](#27)) ([c849d8e](c849d8e)) * no build ([72b0bfb](72b0bfb)) * no-wrap parameter ([#25](#25)) ([38aa353](38aa353)), closes [#17](#17) * space create and register improvements ([#8](#8)) ([8617b49](8617b49)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17