Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add space command with create and register #3

Merged
merged 4 commits into from
Dec 9, 2022
Merged

feat: add space command with create and register #3

merged 4 commits into from
Dec 9, 2022

Conversation

olizilla
Copy link
Contributor

@olizilla olizilla commented Dec 9, 2022

TODO: fix me

❯ ./bin.js space create foo
Created foo
file:///Users/oli/Code/web3-storage/w3cli/node_modules/@web3-storage/access/src/drivers/indexeddb.js:69
    const openReq = indexedDB.open(this.#dbName, this.#dbVersion)
                    ^

ReferenceError: indexedDB is not defined
    at StoreIndexedDB.open (file:///Users/oli/Code/web3-storage/w3cli/node_modules/@web3-storage/access/src/drivers/indexeddb.js:69:21)
    at #getOpenDB (file:///Users/oli/Code/web3-storage/w3cli/node_modules/@web3-storage/access/src/drivers/indexeddb.js:57:18)
    at StoreIndexedDB.load (file:///Users/oli/Code/web3-storage/w3cli/node_modules/@web3-storage/access/src/drivers/indexeddb.js:119:37)
    at create (file:///Users/oli/Code/web3-storage/w3cli/node_modules/@web3-storage/w3up-client/src/index.js:22:27)
    at createSpace (file:///Users/oli/Code/web3-storage/w3cli/index.js:4:24)
    at file:///Users/oli/Code/web3-storage/w3cli/bin.js:24:5
    at o.parse (/Users/oli/Code/web3-storage/w3cli/node_modules/sade/lib/index.js:1:3402)
    at file:///Users/oli/Code/web3-storage/w3cli/bin.js:34:5
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)

Node.js v18.12.1

License: MIT
Signed-off-by: Oli Evans oli@protocol.ai

@olizilla
feat: add space command with create and register
ace2299 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla
chore: lint
c337475 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
alanshaw approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work

@olizilla
fix: latest w3up-client fixes wrong agent bug
012779e 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla
chore: lint
0ab0bdb 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla olizilla merged commit 9c25a2d into main Dec 9, 2022
@olizilla olizilla deleted the create-space branch December 9, 2022 14:30
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Merged
alanshaw pushed a commit that referenced this pull request Dec 14, 2022
@github-actions
chore(main): release 1.0.0 (#29)
b41ab86 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2022-12-14)


### Features

* add `list` command
([#10](#10))
([b6cb1f0](b6cb1f0))
* add `proof add` command
([#24](#24))
([eb32d28](eb32d28))
* add `space` command with `create` and `register`
([#3](#3))
([9c25a2d](9c25a2d))
* add `w3 can store add` and `w3 can upload add` commands
([#26](#26))
([07fa1b0](07fa1b0))
* add `whoami` to print agent DID
([#11](#11))
([e3f2497](e3f2497))
* add delegation create command
([#5](#5))
([272c53a](272c53a))
* add old CLI bin reference
([#4](#4))
([9a0716c](9a0716c))
* delegation ls and proof ls commands
([#22](#22))
([04a7d31](04a7d31))
* sade cli skeleton
([#1](#1))
([3104b9f](3104b9f))
* up command ([#7](#7))
([283b938](283b938))


### Bug Fixes

* add expiration parameter
([#21](#21))
([9457841](9457841))
* better error reporting
([#19](#19))
([0f6a2a6](0f6a2a6)),
closes [#15](#15)
[#16](#16)
* create space on register
([#13](#13))
([f4a1a0f](f4a1a0f))
* dont emit warnings for fetch api
([#9](#9))
([cf52922](cf52922))
* files-from-path with common path prefix removed
([#27](#27))
([c849d8e](c849d8e))
* no build
([72b0bfb](72b0bfb))
* no-wrap parameter
([#25](#25))
([38aa353](38aa353)),
closes [#17](#17)
* space create and register improvements
([#8](#8))
([8617b49](8617b49))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olizilla @alanshaw