fix: add output command to w3 space #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/add-output-command-to-w3-space
branch
from
612f8c8
to
4381c00
Compare
|
Removed for consistency as alternative while talking with @alanshaw |
alanshaw
approved these changes
Mar 20, 2023
vasco-santos
pushed a commit
that referenced
this pull request
Mar 20, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.2](v1.2.1...v1.2.2) (2023-03-20) ### Bug Fixes * drop redudant w3 space command for consistency ([#57](#57)) ([8dfab92](8dfab92)), closes [#44](#44) * warnings about uploads being public/permanent ([84a9fd5](84a9fd5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had no output for
w3 spacecommand resulting in ugly user errors as mentioned in #44.This PR addresses it. There is nothing clear we want to output. Therefore, looked like a good option to list user agent spaces and instruct on how to do other space commands. As alternatives, we can:
delegation,proof, ...Thoughts?
Closes #44