feat!: allow specifying capabilities to receive when authorizing #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
reviewed
Mar 29, 2023
bin.js
Outdated
| @@ -37,7 +37,8 @@ cli | |||
| cli.command('authorize <email>') | |||
| .alias('auth') | |||
| .example('authorize user@example.com') | |||
| .describe('Authorize this agent to interact with the w3up service with any capabilities granted to the given email.') | |||
| .describe('Authorize this agent to interact with the w3up service with capabilities granted to the given email.') | |||
| .option('-c, --can', 'One or more abilities to authorize.', '*') | |||
There was a problem hiding this comment.
I would prefer not to add a default of *. Can we add the flag separately from adding the default?
Not a hard blocker though. I asked for advice on tradeoffs
There was a problem hiding this comment.
Ah yes, will change this now...
alanshaw
changed the title
gobengo
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can specify these, so the agent does not have to receive admin.
This also removes the default
*capability fromw3 delegation create, making the-c, --canflag non-optional.