feat: add ability to specify custom principal #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed by one of the teams integrating with w3up. w3up-client will already fail if you pass a different principal than the store is configured to use, so we don't need to add any extra validation logic - end-users can generate a key with `npx ucan-key ed --json` and set the `W3_PRINCIPAL` environment variable for at least the first invocation of `w3` in a new environment. Setting `W3_PRINCIPAL` on subsequent invocations is optional but will ensure the principal used by the client is always the same.
alanshaw
approved these changes
Aug 25, 2023
travis
pushed a commit
that referenced
this pull request
Aug 25, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](v4.0.0...v4.1.0) (2023-08-25) ### Features * add `space info` command to w3cli ([#83](#83)) ([a72701c](a72701c)) * add ability to specify custom principal with the W3_PRINCIPAL environment variable ([#84](#84)) ([6115101](6115101)) * bump versions of `access` and `w3up-client` ([#81](#81)) ([55de733](55de733)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed by one of the teams integrating with w3up.
w3up-client will already fail if you pass a different principal than the store is configured to use, so we don't need to add any extra validation logic - end-users can generate a key with
npx ucan-key ed --jsonand set theW3_PRINCIPALenvironment variable for at least the first invocation ofw3in a new environment.Setting
W3_PRINCIPALon subsequent invocations is optional but will ensure the principal used by the client is always the same.