fix: do not print error when space is unknown #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olizilla
reviewed
Sep 13, 2023
Co-authored-by: Oli Evans <oli@protocol.ai>
alanshaw
deleted the
fix/do-not-print-error-when-space-is-unknown-to-service
branch
|
this is great - thank you!! |
alanshaw
pushed a commit
that referenced
this pull request
Sep 13, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.1](v4.2.0...v4.2.1) (2023-09-13) ### Bug Fixes * do not print error when space is unknown ([#95](#95)) ([7f693d8](7f693d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the space was not known to the service then that's ok, there's just no info to print about it. Don't make it look like something is wrong, just print the space DID since that's all we know.
Also makes the output a bit nicer by adding a "none" when no providers, and aligning the labels centrally:
Without provider:
(Was previously printing
Error getting info about did:key:z6Mksjp3Mbe7TnQbYK43NECF7TRuDGZu9xdzeLg379Dw66mF: Space not found.)With provider:
Note: I chose to address this here and not alter the service because I think it's probably useful to be able to distinguish programmatically between spaces that are known to the service and spaces that are not, however in this instance it's not haha!